search

atom-haskell / ide-haskell

Haskell IDE plugin for Atom editor
https://atom.io/packages/ide-haskell
Other
233 stars 30 forks source link

Function.extractParams is deprecated. #212

Closed MatthijsBlom closed 6 years ago

MatthijsBlom commented 6 years ago

Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams (<embedded>:127759:20)
MarkerLayer.markPosition (<embedded>:73362:30)
DisplayMarkerLayer.markBufferPosition (<embedded>:128379:58)
TextEditor.addCursorAtBufferPosition (<embedded>:4226:40)
cursors.forEach (C:\Users\Matthijs\.atom\packages\ide-haskell\lib\prettify\index.js:33:24)
Array.forEach (native)
lierdakil commented 6 years ago

What the hell? What Atom version are you using?

lierdakil commented 6 years ago

Quick note: seems TextEditor.addCursorAtBufferPosition(cursor, { autoscroll: false }) triggers this, which is a false positive, since autoscroll is not a marker property, but rather an option for addCursorAtBufferPosition specifically.

lierdakil commented 6 years ago

I believe https://github.com/atom/atom/commit/b362f746f8fb21d9850f02ca82cc50e90e126d38 is at fault

MatthijsBlom commented 6 years ago

What Atom version are you using?

Atom 1.20, in case you are still wondering.

lierdakil commented 6 years ago

Thanks. I'll go ahead and create an issue on atom/atom then.

lierdakil commented 6 years ago

Fixed upstream, will be released as Atom 1.22.