Git status colors on tree view enhancement

[SpikeShape]

Sorry about the weird title of this issue. I didn't know how to call it.

What I am talking about is the git status color in the tree view, when you save a file. It doesn't show them immediately. You have to unfocus and focus it to make it appear. Edit: I just realized that git status coloring does not apply when the tree is not focused while your file is the marked file.

Additionally when you focus a folder it doesn't show the status.

Also: Is there a way of switching the file icon's color to the color you use or the text? The picture shows a changed js file. I think it used to change the color prior to the last big update.

[SpikeShape]

Thanks a lot for the update. Yet, the currently selected file is still not marked as changed when the tree view isn't focused. Unfocused tree:

Focused tree:

[silvestreh]

Yes, that's intentional. Otherwise there would be no way to know if the tree view is focused.

[SpikeShape]

Fair point... Could we somehow show that the file, that is currently marked, has been changed / added since the last stage e. g. changing the file name color to yellow / green respectively?

[silvestreh]

I'll think of something :smile:

[jerone]

What about yellow font color when the tree-view is unfocused?

Tree-view focused	Tree-view unfocused	Solution to show git status on unfocused tree-view

It's kinda irritating that the git status isn't show for the last selected file in the tree-view while the focus is on the editor.

[jerone]

Adding the following code to my styles.less solves it for me on file entry (haven't researched the folder entry):

.tree-view:not(:focus) .list-tree li:not(.list-nested-item):not(.tabBlender).status-modified.selected,
.tree-view:not(:focus) .list-group li:not(.list-nested-item):not(.tabBlender).status-modified.selected,
.tree-view:not(:focus) .list-tree li.list-nested-item > .list-item.status-modified.selected,
.tree-view:not(:focus) .list-group li.list-nested-item > .list-item.status-modified.selected
{
    color: #e3b93c;
}
.tree-view:not(:focus) .list-tree li:not(.list-nested-item):not(.tabBlender).status-added.selected,
.tree-view:not(:focus) .list-group li:not(.list-nested-item):not(.tabBlender).status-added.selected,
.tree-view:not(:focus) .list-tree li.list-nested-item > .list-item.status-added.selected,
.tree-view:not(:focus) .list-group li.list-nested-item > .list-item.status-added.selected
{
    color: #8bc34a;
}

Key is .tree-view:not(:focus) in front of the selectors.

[SpikeShape]

That's what I was thinking about, too. Thanks for the visualization!

On Mon, Feb 29, 2016, 12:40 AM Jeroen van Warmerdam < notifications@github.com> wrote:

What about yellow font color when the tree-view is unfocused? Tree-view focused Tree-view unfocused Solution to show git status on unfocused tree-view [image: focused] https://cloud.githubusercontent.com/assets/55841/13382240/03fd59f6-de70-11e5-9313-0c00c53599d6.png [image: unfocused] https://cloud.githubusercontent.com/assets/55841/13382242/0db4cd62-de70-11e5-916d-f94ca1ae3a0d.png [image: solution] https://cloud.githubusercontent.com/assets/55841/13382245/1947d070-de70-11e5-883b-9c71a98e1e54.png

It's kinda irritating that the git status isn't show for the last selected file in the tree-view while the focus is on the editor.

— Reply to this email directly or view it on GitHub https://github.com/silvestreh/atom-material-ui/issues/217#issuecomment-189955680 .

[jerone]

:+1: