search

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Disabling "Use animations" has unintended side effects on other packages #271

Closed nikolowry closed 8 years ago

nikolowry commented 8 years ago

This was first reported in issue https://github.com/silvestreh/atom-material-ui/issues/131- however, we were unable to collectively pin point why certain users could/couldn't reproduce the bugs.

After setting up a new machine and doing a fresh install - I was able to deduce that the "Use animations" being disabled was the culprit. I'm assuming other packages might have dependent events and event listeners on their UI elements that get overridden and thus "breaking" their packages.

The offending style:

atom-workspace:not(.use-animations) *, 
atom-workspace:not(.use-animations) *::before, 
atom-workspace:not(.use-animations) *::after{
    transition:none !important;
    -webkit-animation-duration:0s !important;
}

I'd suggest maybe targeting elements(buttons, inputs, etc) more specifically, rather then simply disabling all transitions/animations on a global scope.

James-Byrne commented 8 years ago

I can confirm that turning on animations fixed #225 for me

silvestreh commented 8 years ago

Thanks @James-Byrne. Now I have another reason to fix this one 😀