atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Code font is bolder than it should #290

Closed sveggiani closed 8 years ago

sveggiani commented 8 years ago

When this theme is activated, the font in the code panels is bolder than it should, in my opinion. If this is intended it would be awesome to have an option to set this. Check in the screenshot that a font-weight: 600 is being applied.

Reproduction Steps:

  1. Activate the theme
  2. Go to a code panel to see the bolder font.

Expected behavior:

Font weight shouldn't be affected by theme.

Screenshots and GIFs

screen shot 2016-05-23 at 12 25 30 am

Screenshots and GIFs which follow reproduction steps to demonstrate the problem

Atom version: 1.7.3 OS and version: OS X and Windows

Installed packages:

[
    {
        "name": "Sublime-Style-Column-Selection",
        "version": "1.5.1"
    },
    {
        "name": "about",
        "version": "1.4.2"
    },
    {
        "name": "activate-power-mode",
        "version": "0.5.2"
    },
    {
        "name": "archive-view",
        "version": "0.61.1"
    },
    {
        "name": "atom-beautify",
        "version": "0.29.7"
    },
    {
        "name": "atom-css-comb",
        "version": "3.1.0"
    },
    {
        "name": "atom-dark-syntax",
        "version": "0.27.0",
        "theme": "syntax"
    },
    {
        "name": "atom-dark-ui",
        "version": "0.51.0",
        "theme": "ui"
    },
    {
        "name": "atom-light-syntax",
        "version": "0.28.0",
        "theme": "syntax"
    },
    {
        "name": "atom-light-ui",
        "version": "0.43.0",
        "theme": "ui"
    },
    {
        "name": "atom-material-ui",
        "version": "1.2.11",
        "theme": "ui"
    },
    {
        "name": "autocomplete-atom-api",
        "version": "0.10.0"
    },
    {
        "name": "autocomplete-css",
        "version": "0.11.0"
    },
    {
        "name": "autocomplete-html",
        "version": "0.7.2"
    },
    {
        "name": "autocomplete-plus",
        "version": "2.29.1"
    },
    {
        "name": "autocomplete-snippets",
        "version": "1.10.0"
    },
    {
        "name": "autoflow",
        "version": "0.27.0"
    },
    {
        "name": "autosave",
        "version": "0.23.1"
    },
    {
        "name": "background-tips",
        "version": "0.26.0"
    },
    {
        "name": "base16-tomorrow-dark-theme",
        "version": "1.1.0",
        "theme": "syntax"
    },
    {
        "name": "base16-tomorrow-light-theme",
        "version": "1.1.1",
        "theme": "syntax"
    },
    {
        "name": "bookmarks",
        "version": "0.38.2"
    },
    {
        "name": "bracket-matcher",
        "version": "0.81.0"
    },
    {
        "name": "build",
        "version": "0.63.0"
    },
    {
        "name": "character-table",
        "version": "0.4.3"
    },
    {
        "name": "color-picker",
        "version": "2.1.1"
    },
    {
        "name": "command-palette",
        "version": "0.38.0"
    },
    {
        "name": "custom-title",
        "version": "1.0.1"
    },
    {
        "name": "deprecation-cop",
        "version": "0.54.1"
    },
    {
        "name": "dev-live-reload",
        "version": "0.47.0"
    },
    {
        "name": "docblockr",
        "version": "0.7.3"
    },
    {
        "name": "editorconfig",
        "version": "1.4.1"
    },
    {
        "name": "emmet",
        "version": "2.4.3"
    },
    {
        "name": "encoding-selector",
        "version": "0.21.0"
    },
    {
        "name": "exception-reporting",
        "version": "0.37.0"
    },
    {
        "name": "expand-selection-to-quotes",
        "version": "0.7.0"
    },
    {
        "name": "file-icons",
        "version": "1.7.11"
    },
    {
        "name": "find-and-replace",
        "version": "0.199.0"
    },
    {
        "name": "firewatch-syntax",
        "version": "1.0.1",
        "theme": "syntax"
    },
    {
        "name": "fuzzy-finder",
        "version": "1.0.5"
    },
    {
        "name": "git-control",
        "version": "0.7.1"
    },
    {
        "name": "git-diff",
        "version": "1.0.1"
    },
    {
        "name": "git-plus",
        "version": "5.13.4"
    },
    {
        "name": "git-time-machine",
        "version": "1.5.2"
    },
    {
        "name": "go-to-line",
        "version": "0.30.0"
    },
    {
        "name": "grammar-selector",
        "version": "0.48.1"
    },
    {
        "name": "gruvbox-plus-syntax",
        "version": "1.2.0",
        "theme": "syntax"
    },
    {
        "name": "highlight-selected",
        "version": "0.11.2"
    },
    {
        "name": "image-view",
        "version": "0.57.0"
    },
    {
        "name": "incompatible-packages",
        "version": "0.25.1"
    },
    {
        "name": "isotope-ui",
        "version": "2.7.1",
        "theme": "ui"
    },
    {
        "name": "keybinding-resolver",
        "version": "0.35.0"
    },
    {
        "name": "keyboard-localization",
        "version": "1.4.18"
    },
    {
        "name": "language-c",
        "version": "0.51.1"
    },
    {
        "name": "language-clojure",
        "version": "0.20.0"
    },
    {
        "name": "language-coffee-script",
        "version": "0.46.1"
    },
    {
        "name": "language-csharp",
        "version": "0.12.0"
    },
    {
        "name": "language-css",
        "version": "0.36.0"
    },
    {
        "name": "language-gfm",
        "version": "0.85.0"
    },
    {
        "name": "language-git",
        "version": "0.12.1"
    },
    {
        "name": "language-go",
        "version": "0.42.0"
    },
    {
        "name": "language-html",
        "version": "0.44.1"
    },
    {
        "name": "language-hyperlink",
        "version": "0.16.0"
    },
    {
        "name": "language-java",
        "version": "0.17.0"
    },
    {
        "name": "language-javascript",
        "version": "0.110.0"
    },
    {
        "name": "language-json",
        "version": "0.17.6"
    },
    {
        "name": "language-less",
        "version": "0.29.0"
    },
    {
        "name": "language-make",
        "version": "0.21.0"
    },
    {
        "name": "language-mustache",
        "version": "0.13.0"
    },
    {
        "name": "language-objective-c",
        "version": "0.15.1"
    },
    {
        "name": "language-perl",
        "version": "0.32.0"
    },
    {
        "name": "language-php",
        "version": "0.37.0"
    },
    {
        "name": "language-property-list",
        "version": "0.8.0"
    },
    {
        "name": "language-python",
        "version": "0.43.0"
    },
    {
        "name": "language-ruby",
        "version": "0.68.3"
    },
    {
        "name": "language-ruby-on-rails",
        "version": "0.25.0"
    },
    {
        "name": "language-sass",
        "version": "0.46.0"
    },
    {
        "name": "language-shellscript",
        "version": "0.21.0"
    },
    {
        "name": "language-source",
        "version": "0.9.0"
    },
    {
        "name": "language-sql",
        "version": "0.20.0"
    },
    {
        "name": "language-text",
        "version": "0.7.1"
    },
    {
        "name": "language-todo",
        "version": "0.27.0"
    },
    {
        "name": "language-toml",
        "version": "0.18.0"
    },
    {
        "name": "language-xml",
        "version": "0.34.4"
    },
    {
        "name": "language-yaml",
        "version": "0.25.1"
    },
    {
        "name": "line-ending-selector",
        "version": "0.3.1"
    },
    {
        "name": "link",
        "version": "0.31.1"
    },
    {
        "name": "linter",
        "version": "1.11.4"
    },
    {
        "name": "linter-csslint",
        "version": "1.3.2"
    },
    {
        "name": "linter-eslint",
        "version": "7.2.2"
    },
    {
        "name": "linter-scss-lint",
        "version": "3.0.4"
    },
    {
        "name": "linter-tidy",
        "version": "2.1.0"
    },
    {
        "name": "magic-tag",
        "version": "0.2.3"
    },
    {
        "name": "markdown-preview",
        "version": "0.158.0"
    },
    {
        "name": "merge-conflicts",
        "version": "1.4.2"
    },
    {
        "name": "metrics",
        "version": "0.53.1"
    },
    {
        "name": "minimap",
        "version": "4.23.5"
    },
    {
        "name": "notifications",
        "version": "0.63.1"
    },
    {
        "name": "oceanic-next",
        "version": "0.1.2",
        "theme": "syntax"
    },
    {
        "name": "one-dark-syntax",
        "version": "1.2.0",
        "theme": "syntax"
    },
    {
        "name": "one-dark-ui",
        "version": "1.2.0",
        "theme": "ui"
    },
    {
        "name": "one-light-syntax",
        "version": "1.2.0",
        "theme": "syntax"
    },
    {
        "name": "one-light-ui",
        "version": "1.2.0",
        "theme": "ui"
    },
    {
        "name": "open-on-github",
        "version": "1.0.1"
    },
    {
        "name": "open-recent",
        "version": "5.0.0"
    },
    {
        "name": "package-generator",
        "version": "1.0.0"
    },
    {
        "name": "php-cs-fixer",
        "version": "2.5.6"
    },
    {
        "name": "php-twig",
        "version": "4.0.0"
    },
    {
        "name": "pigments",
        "version": "0.26.3"
    },
    {
        "name": "project-manager",
        "version": "2.9.7"
    },
    {
        "name": "rest-client",
        "version": "1.1.0"
    },
    {
        "name": "revert-buffer",
        "version": "0.5.0"
    },
    {
        "name": "save-session",
        "version": "0.15.7"
    },
    {
        "name": "set-syntax",
        "version": "0.3.0"
    },
    {
        "name": "settings-view",
        "version": "0.235.1"
    },
    {
        "name": "snippets",
        "version": "1.0.1"
    },
    {
        "name": "solarized-dark-syntax",
        "version": "1.0.0",
        "theme": "syntax"
    },
    {
        "name": "solarized-light-syntax",
        "version": "1.0.0",
        "theme": "syntax"
    },
    {
        "name": "sort-lines",
        "version": "0.14.0"
    },
    {
        "name": "spell-check",
        "version": "0.67.0"
    },
    {
        "name": "status-bar",
        "version": "1.1.2"
    },
    {
        "name": "string-encoder",
        "version": "0.1.0"
    },
    {
        "name": "styleguide",
        "version": "0.45.2"
    },
    {
        "name": "symbols-view",
        "version": "0.112.0"
    },
    {
        "name": "sync-settings",
        "version": "0.7.2"
    },
    {
        "name": "tabs",
        "version": "0.92.0"
    },
    {
        "name": "tag",
        "version": "0.4.0"
    },
    {
        "name": "timecop",
        "version": "0.33.1"
    },
    {
        "name": "todo-show",
        "version": "1.6.0"
    },
    {
        "name": "tool-bar",
        "version": "0.4.0"
    },
    {
        "name": "tool-bar-almighty",
        "version": "0.6.1"
    },
    {
        "name": "trailing-spaces",
        "version": "0.3.2"
    },
    {
        "name": "tree-view",
        "version": "0.205.0"
    },
    {
        "name": "update-package-dependencies",
        "version": "0.10.0"
    },
    {
        "name": "welcome",
        "version": "0.34.0"
    },
    {
        "name": "whitespace",
        "version": "0.32.2"
    },
    {
        "name": "wrap-guide",
        "version": "0.38.1"
    }
]

Additional information:

silvestreh commented 8 years ago

I'm pretty sure it varies from font to font, but I'm actually not setting the font-width, but rather the font-smoothing, and only on the panels (tree view and tabs).

Here's what I have in my user stylesheets:

atom-text-editor {
    -webkit-font-smoothing: antialiased;
}

This used to be the default behavior, but I changed it due to repeated issue reports.

sveggiani commented 8 years ago

Hi @silvestreh, the problem dissapeared aftern an Atom restart in both machines (OS X , Windows). May be a note about this is a good addition to the Readme.md file.

I'll close this issue. Thank you!

sveggiani commented 8 years ago

Happening again to me with the Atom 1.8.0 update. This times a restart doesn't fix the font rendering problem.

silvestreh commented 8 years ago

My computer died. It might be a while till I can get back to this as I'm in no position to get a new one 😭

sveggiani commented 8 years ago

ohh, @silvestreh I sorry to hear that :( I hope you can get a new one soon I'll try to take a look at this later.

sveggiani commented 8 years ago

@silvestreh I've found the cause of this problem. It's the atom-trailing-spaces that adds the following classes to the body: trailing-spaces-highlight-indentation trailing-spaces-highlight-cursor-lines that match the selectors in https://github.com/atom-material/atom-material-ui/blob/master/styles/text.less#L42 I don't have any experience with atom theming and I'm trying to know if this should be somehow scoped or if the other package classes need to be renamed. Any help you could provide me will be much appreciated. Thanks!