atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
816 stars 203 forks source link

Icon in update panel doesn't match theme color #293

Closed JamesCoyle closed 8 years ago

JamesCoyle commented 8 years ago

The heart/sand timer icon in the update panel doesn't match the theme color. Would be nice if it did.

image

silvestreh commented 8 years ago

Some things don't have to match the theme color as they're colored based on their status. I mean, you wouldn't expect an error message to be teal-colored, it should be red. Same goes for success, information, and warning.

JamesCoyle commented 8 years ago

The blue isn't showing anything though. If it was red, yellow or green showing error, warning or failure sure. But it's always just blue and looks out of place.

silvestreh commented 8 years ago

I'm sure it does show on other elements. The update counter in the status bar, for instance, is also blue. The hourglass and magnifier icons that appear while searching or waiting for an async method to finish, are also blue. Notifications are blue when they're of type info (like this atom.notifications.addInfo('test');.)

In short: the info status is colored blue. Many packages use the text-info class and expect it to be colored blue.

Check Atom's style guide, the Text classes section specifically. Here's what it looks like:

captura de pantalla 2016-05-29 a las 21 51 30

In that screenshot the "highlighted" text will change to match the theme's main color.

In my case is purple because I love how it kinda matches one of my favorite anime pieces 😁