atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

atom-material-ui's predefined colour setting now also affects cursors and line numbers #309

Closed ghost closed 8 years ago

ghost commented 8 years ago

Pretty self-explanatory.

I thought this minor change complimented the theme changes when the user chooses a different colour.

silvestreh commented 8 years ago

This is something I've been wanting to do for a while, but I'm not comfortable with modifying other themes or messing with the syntax theme in the UI theme.

I still can't decide between scoping this only to atom-material-syntax themes or making it an optional feature in the settings. 😕

ghost commented 8 years ago

I would definitely go with making in an optional feature (obsviously default value will be false).

I'm probably just saying that because I created this PR and want this feature haha 😉

silvestreh commented 8 years ago

I'll merge this and implement the toggle 👍

ghost commented 8 years ago

Legendary 👍