atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Failed to change UI color on latest Atom from git Master #318

Closed Nikki1993 closed 8 years ago

Nikki1993 commented 8 years ago

Title says it all. Changing primary color causes Material UI theme to crash

Reproduction Steps for Atom from Git Master:

  1. Open material UI settings
  2. Try to change primary color
  3. Boom, get crashed.

Expected behavior:

Color changed.

Theme crashed and reverts to default teal color.

Atom version: 1.11-dev OS and version: Solus OS 1.2.1

Stack trace and packages

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.11.0-dev-d47fd28 Electron Version: 0.37.8 System: linux 4.7.0 Thrown From: atom-material-ui package, v1.3.3

Stack Trace

Failed to activate the atom-material-ui theme

At missing opening `(` in /home/nikki/.atom/packages/atom-material-ui/styles/custom.less:2:0

LessError: missing opening `(`
  at /home/nikki/.atom/packages/atom-material-ui/styles/custom.less:2:0

Commands

     -3:08.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -1:02.7.0 tree-view:remove-project-folder (span.name.icon.icon-repo)
     -0:59.2.0 application:add-project-folder (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)

Config

{
  "core": {
    "autoHideMenuBar": true,
    "themes": [
      "atom-material-ui",
      "google-dark-syntax"
    ]
  },
  "atom-material-ui": {
    "colors": {
      "genAccent": true,
      "paintCursor": true,
      "predefinedColor": "Blue",
      "accentColor": {
        "_red": 175,
        "_green": 0,
        "_blue": 16,
        "_alpha": 1
      }
    },
    "tabs": {
      "tintedTabBar": true
    },
    "treeView": {
      "blendTabs": true,
      "compactList": true
    },
    "ui": {
      "panelContrast": true,
      "panelShadows": true
    }
  }
}

Installed Packages

# User
angularjs, v0.3.5 (active)
atom-beautify, v0.29.10 (inactive)
atom-live-server, v1.2.5 (inactive)
atom-material-syntax, v0.4.6 (inactive)
atom-material-ui, v1.3.3 (active)
atom-ternjs, v0.14.2 (active)
atom-typescript, v10.1.6 (active)
autoclose-html, v0.23.0 (active)
color-picker, v2.2.2 (active)
docs-snippets, v0.8.0 (active)
emmet, v2.4.3 (active)
file-icons, v1.7.18 (active)
fonts, v1.6.0 (active)
git-time-machine, v1.5.3 (inactive)
google-dark-syntax, v3.1.0 (active)
highlight-selected, v0.11.2 (active)
improved-chester-atom-syntax, v0.2.0 (inactive)
linter, v1.11.16 (active)
linter-eslint, v7.2.4 (active)
linter-jshint, v2.1.0 (active)
linter-scss-lint, v3.0.4 (active)
minimap, v4.24.7 (active)
minimap-find-and-replace, v4.5.1 (active)
minimap-highlight-selected, v4.4.0 (active)
open-recent, v5.0.0 (active)
pigments, v0.31.2 (active)
pretty-json, v1.6.0 (active)
seti-syntax, v1.0.1 (inactive)
seti-ui, v1.3.2 (inactive)
sync-settings, v0.7.2 (active)
todo-show, v1.7.0 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (inactive)
base16-tomorrow-dark-theme, v1.1.0 (inactive)
base16-tomorrow-light-theme, v1.1.1 (inactive)
one-dark-ui, v1.5.0 (inactive)
one-light-ui, v1.5.0 (inactive)
one-dark-syntax, v1.3.0 (inactive)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.6.0 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.2 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.41.1 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.39.0 (active)
find-and-replace, v0.201.0 (inactive)
fuzzy-finder, v1.3.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.1 (active)
image-view, v0.58.2 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (active)
metrics, v0.53.1 (active)
notifications, v0.65.0 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.241.2 (active)
snippets, v1.0.2 (active)
spell-check, v0.67.1 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.0 (active)
symbols-view, v0.113.0 (inactive)
tabs, v0.100.2 (active)
timecop, v0.33.2 (active)
tree-view, v0.208.3 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.34.0 (active)
whitespace, v0.33.0 (active)
wrap-guide, v0.38.1 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.2 (active)
language-csharp, v0.12.1 (active)
language-css, v0.37.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.42.1 (active)
language-html, v0.45.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.23.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.2 (active)
language-less, v0.29.5 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.2 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.69.0 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.56.0 (active)
language-shellscript, v0.22.4 (active)
language-source, v0.9.0 (active)
language-sql, v0.23.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.9 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages
silvestreh commented 8 years ago

Yes, I noticed this too. I didn't bother taking a look into it because it's not even a beta release. We'll see again once 1.11 hits the beta channel.

silvestreh commented 8 years ago

This was an issue in atom/settings-view#832. Works like a charm now.

Nikki1993 commented 8 years ago

Awesome sauce!