search

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Remove tooltip max-width limit #324

Closed macklinu closed 7 years ago

macklinu commented 8 years ago

Fixes #315

I referenced a theme that didn't suffer from this issue to see how the tooltips were styled. atom/one-dark-ui's .tooltip style does not set a max-width on its tooltips. Thoughts on going with this approach? It looks to fix this issue, but I'm not sure if it has other implications.

Before

typescript-tooltip-before

After

typescript-tooltip-after
silvestreh commented 8 years ago

Awesome! Did you test how this would look with extremely long paths in a tab's tooltip?

macklinu commented 8 years ago

Good idea. I'll take another look at this and update with more screenshots.

macklinu commented 8 years ago

I see what you're talking about now.

Before the change:

image

After the change:

image

What do you think about this? It doesn't run outside of the window, but the tab tooltips look better before this change, in my opinion. I'll defer to you on this one - let me know if I can explore anything else too!

bennypowers commented 8 years ago

setting word-break to normal would allow long paths to break at the max-width

silvestreh commented 7 years ago

@bennypowers Yeah, but this PR removes that max-width.

macklinu commented 7 years ago

I'm not sure what to do this with this PR - going to close this for now.