atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Notification text wraps prematurely #331

Closed zmb3 closed 7 years ago

zmb3 commented 8 years ago

It seems that the text in Atom notifications is wrapping prematurely.

In this particular case, I have two notifications stacked on top of eachother, and the notification on the bottom is exhibiting the problem. If I clear the topmost notification so that there is only one notification remaining, the layout corrects itself.

Reproduction Steps:

This is easy to reproduce with the Go-Plus package, but requires a bit of setup if you're not a Go developer. I'm happy to share my screen and show a repro.

  1. Install Go toolchain and set $GOPATH
  2. Launch Atom
  3. Invoke the golang: update packages command and observe the notifications

Expected behavior:

Text wraps only after using all available horizontal space.

Observed behavior:

Text only fills about 50% of the horizontal space and then wraps.

Screenshots and GIFs

Lower notification text wrapping: image

Dev tools view: image

After dismissing the upper notification the layout corrects itself: image

Atom version: 1.11.0-beta5 OS and version: macOS Sierra

Installed packages:

atom-material-syntax@0.4.6 atom-material-ui@1.3.6 atom-pair@2.0.10 autocomplete-go@1.2.0 builder-go@1.0.1 git-plus@5.17.1 go-add-tags@0.0.0 go-config@1.2.4 go-debug@0.1.22 go-get@2.0.0 go-hyperclick@1.1.0 go-plus@4.2.0 godoc@1.0.0 gofmt@1.2.0 gometalinter-linter@1.2.1 gorename@1.1.0 hyperclick@0.0.38 linter@1.11.16 linter-eslint@7.3.2 linter-js-standard@3.4.1 linter-js-standard-jsx@4.1.2 material-syntax@0.5.0 navigator-godef@1.1.0 react@0.16.0 tester-go@1.1.0

Additional information:

silvestreh commented 7 years ago

I can't seem to reproduce this. Could you take a screenshot of the markup rendered by Chromium? Open Atom's DevTools and take a screenshot of the HTML.

zmb3 commented 7 years ago

Does this help?

image

silvestreh commented 7 years ago

it sure does. now I can simulate those notifications manually. thanks!

silvestreh commented 7 years ago

Ok, looks like I managed to reproduce and fix this. Here's what it should look like now:

captura de pantalla 2016-11-27 a las 5 17 22 p m

I'll publish a new patch so you can test it 😄

silvestreh commented 7 years ago

Should be fixed in 1.3.8 which I just pushed to APM. Thanks for your help! 😄

zmb3 commented 7 years ago

Yep, the fix looks great. Thanks!