atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Background color renders badly with dark syntax themes #335

Closed ghost closed 7 years ago

ghost commented 8 years ago

Background color for dark syntax themes renders incorrectly.

Reproduction Steps:

  1. Use the Material UI theme
  2. Use a dark syntax theme (Material, Atom Dark, base 16 dark...)
  3. Open a file an type some text

Expected behavior:

Background color should render on the whole background

Observed behavior:

Background is rendered with different color rectangles that move when the cursor moves to different lines.

Screenshots and GIFs

sans titre

Atom version: 1.11.1 OS and version: macOS Sierra

Installed packages:

Additional information:

I am not a hundred percent sure it is because of Material UI but I think it is, as it happens with several syntax themes. The problem is not reproduced with light themes.

arussellsaw commented 8 years ago

the issue is present in light themes, just less visible

tilt your screen if you cannot see it, it's very faint. screen shot 2016-10-28 at 11 43 40

schrej commented 8 years ago

This is not an issue of this theme, it isn't even a atom problem, it's a rendering issue with chrome (atom/atom#12634). It's fixed already and as soon as electron adopts chromium 54 and atom adopts the new electron version it will be resolved by an atom update.

In the meantime start atom with --disable-gpu for correct rendering.

justinschier commented 8 years ago

I'm having the same issue in 1.11.2 in macOS Sierra when using Atom Material theme and Atom Material Dark as the syntax theme. It flashes when I just move my mouse around.

image

schrej commented 8 years ago

@justinschier did you read my message above?

silvestreh commented 7 years ago

I'll close this since it's not related to the theme and the answer was shared by @schrej (thank you for enlightening us!)

montanaflynn commented 7 years ago

Any update on this? It's now May 2017 and I just upgraded to Sierra and now this is happening.

I even tried starting atom with --disable-gpu as suggested and that made no difference.

montanaflynn commented 7 years ago

Here's an open issue on the main atom repo that has more updates.

https://github.com/atom/atom/issues/12634

They also suggested using the flag atom --enable-gpu-rasterization but that didn't work for me on my external display (the problem isn't apparent on my macbook screen at all)

silvestreh commented 7 years ago

@montanaflynn it's technically not an issue with the theme, but with Electron

stefanooliveira commented 6 years ago

I solved this problem by going into settings > Core settings > Color Profile > choose ¨Use sRGB color profile¨ instead of ¨Use color profile configured in the operating system¨.

Also, there is another way that shall work. Go to Ubuntu Settings (if you are using Ubuntu) > Devices > Color > and disable ¨Laptop screen¨ profile.

Both ways worked just great for me. Hope this helps.

deviantony commented 6 years ago

@stefanocampos thanks for sharing this ! Was having the same issue with Atom 1.29.

chrisk8er commented 6 years ago

@stefanocampos thanks, works perfectly...