search

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Deprecated Selectors #337

Closed Nikki1993 closed 7 years ago

Nikki1993 commented 7 years ago

Latest Atom from master, 1.13.0-dev at the time of writing, reports deprecated selectors for atom editor due to removal of shadow dom.

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

atom-text-editor[mini], atom-text-editor[mini]::shadow => atom-text-editor[mini], atom-text-editor[mini]
.paint-cursor atom-text-editor[mini] .cursor, .paint-cursor atom-text-editor[mini]::shadow .cursor => .paint-cursor atom-text-editor[mini] .cursor, .paint-cursor atom-text-editor[mini] .cursor
atom-text-editor[mini]::before, atom-text-editor[mini]::shadow::before => atom-text-editor[mini]::before, atom-text-editor[mini]::before
.use-animations atom-text-editor[mini]::before, .use-animations atom-text-editor[mini]::shadow::before => .use-animations atom-text-editor[mini]::before, .use-animations atom-text-editor[mini]::before
atom-text-editor[mini] .placeholder-text, atom-text-editor[mini]::shadow .placeholder-text => atom-text-editor[mini] .placeholder-text, atom-text-editor[mini] .placeholder-text
atom-text-editor[mini] .selection .region, atom-text-editor[mini]::shadow .selection .region => atom-text-editor[mini] .selection .region, atom-text-editor[mini] .selection .region
.settings-view .section atom-text-editor[mini] .selection .region, .settings-view .section atom-text-editor[mini]::shadow .selection .region, .settings-view .section atom-text-editor[mini] .selection .region, .settings-view .section atom-text-editor[mini]::shadow .selection .region => .settings-view .section atom-text-editor[mini] .selection .region, .settings-view .section atom-text-editor[mini] .selection .region, .settings-view .section atom-text-editor[mini] .selection .region, .settings-view .section atom-text-editor[mini] .selection .region
atom-text-editor, atom-text-editor::shadow => atom-text-editor, atom-text-editor
.paint-cursor atom-text-editor .cursor, .paint-cursor atom-text-editor::shadow .cursor => .paint-cursor atom-text-editor .cursor, .paint-cursor atom-text-editor .cursor
.paint-cursor atom-text-editor .gutter .cursor-line, .paint-cursor atom-text-editor::shadow .gutter .cursor-line => .paint-cursor atom-text-editor .gutter .cursor-line, .paint-cursor atom-text-editor .gutter .cursor-line
.paint-cursor atom-text-editor .gutter .cursor-line-no-selection, .paint-cursor atom-text-editor::shadow .gutter .cursor-line-no-selection => .paint-cursor atom-text-editor .gutter .cursor-line-no-selection, .paint-cursor atom-text-editor .gutter .cursor-line-no-selection
atom-text-editor .find-result .region, atom-text-editor::shadow .find-result .region => atom-text-editor .find-result .region, atom-text-editor .find-result .region
atom-text-editor[mini].is-focused, atom-text-editor[mini].is-focused::shadow => atom-text-editor[mini].is-focused, atom-text-editor[mini].is-focused
atom-text-editor[mini].is-focused::before, atom-text-editor[mini].is-focused::shadow::before => atom-text-editor[mini].is-focused::before, atom-text-editor[mini].is-focused::before
.settings-view .section atom-text-editor[mini].is-focused .selection .region, .settings-view .section atom-text-editor[mini].is-focused::shadow .selection .region, .settings-view .section atom-text-editor[mini].is-focused .selection .region, .settings-view .section atom-text-editor[mini].is-focused::shadow .selection .region => .settings-view .section atom-text-editor[mini].is-focused .selection .region, .settings-view .section atom-text-editor[mini].is-focused .selection .region, .settings-view .section atom-text-editor[mini].is-focused .selection .region, .settings-view .section atom-text-editor[mini].is-focused .selection .region
atom-panel.modal atom-text-editor[mini], .overlay atom-text-editor[mini], atom-panel.modal atom-text-editor[mini]::shadow, .overlay atom-text-editor[mini]::shadow => atom-panel.modal atom-text-editor[mini], .overlay atom-text-editor[mini], atom-panel.modal atom-text-editor[mini], .overlay atom-text-editor[mini]
.select-list atom-text-editor[mini], .popover-list atom-text-editor[mini], .select-list atom-text-editor[mini]::shadow, .popover-list atom-text-editor[mini]::shadow => .select-list atom-text-editor[mini], .popover-list atom-text-editor[mini], .select-list atom-text-editor[mini], .popover-list atom-text-editor[mini]
.styleguide .select-list atom-text-editor[mini], .styleguide .popover-list atom-text-editor[mini], .styleguide .select-list atom-text-editor[mini]::shadow, .styleguide .popover-list atom-text-editor[mini]::shadow => .styleguide .select-list atom-text-editor[mini], .styleguide .popover-list atom-text-editor[mini], .styleguide .select-list atom-text-editor[mini], .styleguide .popover-list atom-text-editor[mini]
atom-text-editor .decoration.linter-row .linter-gutter.linter-highlight.warning, atom-text-editor::shadow .decoration.linter-row .linter-gutter.linter-highlight.warning => atom-text-editor .decoration.linter-row .linter-gutter.linter-highlight.warning, atom-text-editor .syntax--decoration.linter-row .linter-gutter.linter-highlight.syntax--warning
atom-text-editor .decoration.linter-row .linter-gutter.linter-highlight.error, atom-text-editor::shadow .decoration.linter-row .linter-gutter.linter-highlight.error => atom-text-editor .decoration.linter-row .linter-gutter.linter-highlight.error, atom-text-editor .syntax--decoration.linter-row .linter-gutter.linter-highlight.syntax--error
atom-text-editor .line.conflict-ours, atom-text-editor::shadow .line.conflict-ours => atom-text-editor .line.conflict-ours, atom-text-editor .line.conflict-ours
atom-text-editor .line.conflict-ours.cursor-line, atom-text-editor::shadow .line.conflict-ours.cursor-line => atom-text-editor .line.conflict-ours.cursor-line, atom-text-editor .line.conflict-ours.cursor-line
atom-text-editor .line.conflict-ours .source, atom-text-editor::shadow .line.conflict-ours .source => atom-text-editor .line.conflict-ours .source, atom-text-editor .line.conflict-ours .syntax--source
atom-text-editor .line.conflict-theirs, atom-text-editor::shadow .line.conflict-theirs => atom-text-editor .line.conflict-theirs, atom-text-editor .line.conflict-theirs
atom-text-editor .line.conflict-theirs.cursor-line, atom-text-editor::shadow .line.conflict-theirs.cursor-line => atom-text-editor .line.conflict-theirs.cursor-line, atom-text-editor .line.conflict-theirs.cursor-line
atom-text-editor .line.conflict-theirs .source, atom-text-editor::shadow .line.conflict-theirs .source => atom-text-editor .line.conflict-theirs .source, atom-text-editor .line.conflict-theirs .syntax--source
.debugger-editor atom-text-editor, .debugger-editor atom-text-editor::shadow => .debugger-editor atom-text-editor, .debugger-editor atom-text-editor
.nuclide-file-tree-working-set-name-outline atom-text-editor::shadow .placeholder-text => .nuclide-file-tree-working-set-name-outline atom-text-editor .placeholder-text
.nuclide-file-tree-working-set-name-outline atom-text-editor::shadow .text => .nuclide-file-tree-working-set-name-outline atom-text-editor .syntax--text
.nuclide-file-tree-working-set-name-outline atom-text-editor::shadow .selection .region => .nuclide-file-tree-working-set-name-outline atom-text-editor .selection .region
atom-panel.modal .terminal-plus-dialog atom-text-editor[mini], atom-panel.modal .terminal-plus-dialog atom-text-editor[mini]::shadow => atom-panel.modal .terminal-plus-dialog atom-text-editor[mini], atom-panel.modal .terminal-plus-dialog atom-text-editor[mini]

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

simurai commented 7 years ago

Here a guide (still WIP): https://github.com/atom/flight-manual.atom.io/blob/7d0d8b9213472ef054b3628f6b104b402a57e598/content/shadow-dom/sections/removing-shadow-dom-styles.md#when-should-i-migrate-my-themepackage

silvestreh commented 7 years ago

Thanks! I'll pull from master and rebuild to check this out.