keep icon colors in tabs

[ilmam]

I use "file-icons" to display colored icons in atom tabs. After switching to atom-material-ui, and setting tainted tab bar color. I lost the icons colors. This is important to locate the files easily. Can I hack this icon colors in material-ui ?

[silvestreh]

I overrode the color when using tinted tabs for the simple reason that if you have a green icon with a green background you wouldn't see it. I doubt that this can be reverted by using your user stylesheets, but it doesn't hurt to try.

[eminos]

It seems the icon colors are lost on 2.0, even without Tinted tab bar.

[doryphores]

@silvestreh This line here overrides tab icon colors regardless of tinted tab use.

[sbywater-rp]

This bugs me a lot too. @doryphores link is broken, here is the code in master that overrides the color. @silvestreh Making this color override optional would be much appreciated.

[mrleblanc101]

I've added this to my stylesheet in the meantime...

.amu-tinted-tab-bar atom-pane .tab-bar .tab .title[data-path]::before {
    color: inherit !important;
}

atom-pane .tab-bar .tab .title[data-path]::before {
    color: inherit !important;
}

I hope this is getting a fix soon, I don't like that atom-material-ui try to dictate how other packages should behave. My custom theme color has enough contrast with the yellow and green using by VCS coloring option in atom tab and file-icons.

As this option is not enabled by default and is pretty hard to find, I think atom-material-ui shouldn't overwrite the CSS "just in case".

[Alhadis]

Hey guys, maintainer of file-icons here. I've submitted a pull-request to address this. However, it's dependent on a change I had to make to the package, so it therefore won't take hold until the next release. I'll endeavour to get one cut shortly after the PR's made it upstream.

[gluons]

@Alhadis Did you mean #439 PR? Your PR link is this issue. 😅

[Alhadis]

Ugh... 😥 Yeah, I did. #349, #439... mistyped the first two digits. Updated my response.