search

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Material-Ui's Big Button Covers Part of the Text in Merge Conflicts #351

Closed pingshunhuangalex closed 7 years ago

pingshunhuangalex commented 7 years ago

Honestly, I'm not sure who I should turn to regarding this issue. Since Atom Merge Conflicts hasn't been updated for ages, I thought I may have a better shot here.

I'm using material-ui and material dark syntax, and material-ui uses a larger button compared to other themes. This looks great, but it introduces a problem when using Atom Merge Conflicts. The first line of the conflicts will be entirely covered due to the size of the button elements. Just wonder if there is any chance this theme can use a smaller button like those in the defaults, or if the developer can find some kind of a workaround. (The issue is also raised here: https://github.com/smashwilson/merge-conflicts/issues/250) Thanks.

image

pingshunhuangalex commented 7 years ago

Hi @silvestreh Just wonder if there is any plan on getting this issue fixed as Merge Conflicts is a big plus for atom itself. Thanks.

silvestreh commented 7 years ago

Yeah, I'm working on a major refactor which will, hopefully, make the theme "more compatible" with other packages.

pingshunhuangalex commented 7 years ago

Hi @silvestreh Instead of opening new issues, just want to list another colouring issue I noticed recently. It's the warning block shown for linter-flake8 (Issue). Hope they will all be fixed in the coming major refactor. Thanks.

Inline Warning Text for Flake8 (control via variable background-color-warning): image

Arcanemagus commented 7 years ago

That is actually a Linter issue (https://github.com/steelbrain/linter/issues/1317), the text color was being forced to white instead of using a theme variable.

pingshunhuangalex commented 7 years ago

Thanks @Arcanemagus for the support on the Linter issue. I guess people just read reported issues too quickly, and sometimes it's just really hard to say whether the background colour or the text colour should be changed, especially when they are maintained by two different developers.