search

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Panel shading inconsistent #353

Closed jstocksix closed 7 years ago

jstocksix commented 7 years ago

Unsure if bug or I need to add some custom styling, although this issue only apparent with the material-ui and material-syntax packages (which I love, but this issue is distracting).

Thanks so much for the work so far though!

Reproduction Steps:

Any text file.

Expected behaviour:

Consistent shading across panel regardless of line length or position of cursor.

Observed behavior:

Shading appears to be padded around longer lines of text, and follows the position of the cursor (line is highlighted) as well. Padding appears to be 6 lines 'long'.

Screenshots and GIFs

screen shot 2017-02-10 at 11 59 07

screen shot 2017-02-10 at 11 57 16

Atom version: 1.14.1 OS and version: macOS Sierra

silvestreh commented 7 years ago

This is not an issue with the theme, but with Electron itself. Check #335 for further info 👍

jstocksix commented 7 years ago

Ahh yep, that makes sense. I did think it might have been something further upstream than material-ui... Thanks for the link and thanks for your great work!