Rename "Accent" color to "Secondary" to avoid confusion

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines

MIT License

817 stars 204 forks source link

Closed bajanbentley closed 7 years ago

bajanbentley commented 7 years ago

The primary theme colour option changes the accent colour instead. Meanwhile the accent colour picker doesn't do anything.

Screenshots and GIFs

Screenshots and GIFs which follow reproduction steps to demonstrate the problem

Atom version: [1.14.2] OS and version: [Ubuntu 16.10]

silvestreh commented 7 years ago

This is not an issue. It's designed to be like this. I should rename Accent to Secondary to avoid confusion.

The accent color will be used to underline tabs when you have "tinted tab bar" enabled. I see how can this be confusing, but it's a naming issue 😄

I'll leave this issue open as a reminder of what I have to do.

Thanks!

bajanbentley commented 7 years ago

Oho, thanks for the clarification :)

silvestreh commented 7 years ago

This is fixed in 2.0 which is available for Atom 1.17-beta users.