Closed timomeh closed 7 years ago
I agree about the looks, I'm actually working on a new codebase to mitigate these kind of issues.
About the Shift+↩… it's weird because I did not set nor overrode any event listeners. Are you sure it's caused by this theme?
Oh my god that's so embarrassing... I've recently overridden shift-enter, at the same time as I switched to atom-material-ui. I totally forgot about that. 😥
Yeah. shift-enter works. I'm sorry for that. Totally my fault.
As you said, an improvement of the looks would be great. But the keystroke works, so I'm closing this.
@timomeh nothing to be embarrassed about! You wouldn't believe the times where I found myself blocked because of a small, almost obvious, little issue. It happens more often than I'd like to admit. 😁
Reproduction Steps:
Expected behavior:
Pressing shift-enter should cause the flagged files to be staged, or rather trigger a press on the "Apply" button.
Observed behavior:
shift-enter doesn't work in atom-material-ui, but it works in Themes like OneDark.
Screenshots and GIFs
(I'm pressing shift-enter at the end, but I'm too lazy to use a keycaster. 😄)
Atom version: 1.14.4 OS and version: macOS 10.12.3
Installed packages:
Bonus Points:
?
andM
in the GIF) could have more paddingI take a look at this later to open maybe a PR, but I can't promise anything, also because I don't know if I know where to start. 😄