search

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Error Annotation Table in Linter 2.0 #369

Closed ghost closed 7 years ago

ghost commented 7 years ago

Many thanks for all your work on the UI!

After the atom linter got updated to ver. 2 the status bar annotation was changed to a table with three numbers. The colors of the small boxes and fonts are taken from the UI and I was wondering if it would be possible to modify them so there are a bit easier to read and look cleaner? Thanks in advance for considering this.

screenshot from 2017-03-15 23-54-46 screenshot from 2017-03-16 00-01-51

silvestreh commented 7 years ago

I'll take a look. I'm focusing on the 2.0 branch, but that will require Atom 1.17 (currently not even in Beta)

ghost commented 7 years ago

Great, many people are using the linter package so I am sure it would be really appreciated. Keep up the good work.

ghost commented 7 years ago

+1

The font color depends on accent it seems. Also a different color for the small boxes would be nice (or no boxes at all would be even better).

screenshot from 2017-04-27 13-09-07

silvestreh commented 7 years ago

This is what it looks like in the 2.0 branch.

captura de pantalla 2017-04-27 a la s 14 30 19

I'm not making color adjustments specifically for linter, so it'll pick up the theme's variables.

silvestreh commented 7 years ago

Turns out it didn't look quite alright with a light syntax theme, so I ended up touching the colors a bit in the end… here's what it'll look like when Atom 1.17 hits!

captura de pantalla 2017-04-27 a la s 14 40 15 captura de pantalla 2017-04-27 a la s 14 40 29

Arcanemagus commented 7 years ago

@silvestreh If there are things that should be fixed in linter-ui-default instead of here feel free to file issues. I know @steelbrain isn't a UI guy, and I don't really know it either, so I'm sure there are things that are being done wrong there 😉.

silvestreh commented 7 years ago

@Arcanemagus Material UI was to blame for this one in particular (looks just fine on One Light/Dark). But yeah, I'll sure file an issue or send a PR if I find something off in linter-ui-default :)

silvestreh commented 7 years ago

This is fixed in 2.0 available for Atom 1.17-beta.