search

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Big UI change in Atom 1.17.0-beta0 #376

Closed pingshunhuangalex closed 7 years ago

pingshunhuangalex commented 7 years ago

The coming Atom 1.17.0-beta0 introduced a lot of things in UI which breaks the theme in many aspects. The most noticeable one is the panel contrasting stops working and there is an obvious black line between tree view and workspace in tab section.

image

The latest version also introduced the concept of dock where the theme may need to adapt too.

silvestreh commented 7 years ago

Thanks for the heads up! I'm targeting Atom 1.17 in the 2.0 branch… I'll pull the latest changes from Atom's repo and rebuild 👍

simonepri commented 7 years ago

Also the scroll of the tree-view 0.217.0-3 does not work anymore in Atom 1.17.0-beta0 with atom-material-ui 1.3.9

silvestreh commented 7 years ago

@simonepri what do you mean by the scroll?

pingshunhuangalex commented 7 years ago

@silvestreh It means if the content is longer than the height of the tree view, there will be no scroll bar shown, nor does it respond to mouse wheel for scrolling.

Can confirm this on my end too, and it works on Atom's default theme, so it should be related to atom-material-ui

silvestreh commented 7 years ago

Oh, it's absolutely broken then! That's odd because I don't remember messing with the scroll behavior… Anyway, it seems to be working just fine on the 2.0 branch.

pingshunhuangalex commented 7 years ago

@silvestreh I'm really looking forward to 2.0, so I'll just need to wait for the official 1.17.0 to come right? I heard material-ui will be compatible with nuclide in 2.0. Am I right?

silvestreh commented 7 years ago

@pingshunhuangalex yeah! 2.0 will be 99% less awkward with all packages. 😄

simonepri commented 7 years ago

@silvestreh Could you publish on apm a beta version of the 2.0 branch ?

silvestreh commented 7 years ago

@simonepri I don't think I can publish beta versions to APM.

silvestreh commented 7 years ago

This is fixed in 736a966bdce11108c24f38d78bd10900da51ac09. I'll leave the issue open for visibility while 2.0 remains unreleased.

Evpok commented 7 years ago

Any ETA for 2.0 ?

silvestreh commented 7 years ago

@Evpok as soon as Atom 1.17 becomes the latest stable

aemino commented 7 years ago

Suggestion for people who don't want to disable the theme while they wait... You can hackishly install 2.0 by cloning the repository into .atom/packages, using git checkout 2.0 in the repository directory, and then relaunching Atom.

However, this has some... strange side effects. image

rwatts3 commented 7 years ago

btw 2.0 is absolutely amazing, very happy to see this in development.

Evpok commented 7 years ago

@silvestreh Could you make a pre-release for 1.17-beta users ?

silvestreh commented 7 years ago

@Evpok you can clone the repo and link it as a package. 

git clone git@github.com:atom-material/atom-material-ui.git
cd atom-material-ui
git fetch origin
git checkout 2.0
apm link
ghost commented 7 years ago

@silvestreh Didn't work with SSH; seems to over HTTPS. Odd.

silvestreh commented 7 years ago

2.0 is available for Atom 1.17-beta users. Upgrade and flood the issue tracker! 😆