search

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 204 forks source link

Debugging text printed to console #388

Closed Arcanemagus closed 7 years ago

Arcanemagus commented 7 years ago

Some debugging text is printed to the console.

Reproduction Steps:

  1. Start Atom with this theme active.
  2. Open the developer tools and check the Console.

Expected behavior:

Nothing printed to the console when running Atom normally.

Observed behavior:

Some debugging text is printed to the console. Perhaps this should be wrapped in a check on atom.inDevMode()?

Screenshots and GIFs

image

Atom version: v1.17.0-beta4 OS and version: Windows 10 x64

silvestreh commented 7 years ago

Yeah, I completely forgot about it 😅 … I think I already removed those logs in my local copy.

EDIT: Yeah, I removed them and pushed the changes to the repo. Still didn't publish a patch for it though.

Arcanemagus commented 7 years ago

Closing since it's fixed in the repo then 😉.