Closed pingshunhuangalex closed 6 years ago
Your background is nearly black (#141414
). Now that you bring this up I realize I'm not yet done with buttons. Ideally, they'll receive the theme's primary color if they're primary buttons (btn-primary
I think was the className), otherwise they should match the background color.
Cool. I thought the background is just material-ui-dark
background right? I didn't customise background using CSS on my own. Anyway, using primary color would be nice, or using accent color like what we had in 1.x is also fine.
Don't forget to check the shadow when the button is hovered over. I think I saw a thin black border outside the hovered shadow which may be a bug.
The theme doesn't seem to cover the Package rebuild section (div with class incompatible-package
).
Reproduction Steps:
Material UI 2.0
Expected behavior:
Button background should have more contrast to notification background
Observed behavior:
Button background is the same as notification background, and if I have a close look at it, there seems to have a black border outside the button shadow when I hover over the button.
Screenshots and GIFs
Atom version:
Atom 1.17.0-beta4
OS and version:Windows 10 64-bit
Installed packages: