search

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
816 stars 203 forks source link

atom-text-editor[mini] didn't get correct font size #407

Open btstw opened 7 years ago

btstw commented 7 years ago

font size are smaller than setting

Reproduction Steps:

  1. Update this package.
  2. I notice font size in search bar become smaller than previous version, try go to setting to fix it.
  3. When disable this theme font size setting are fine.

Expected behavior:

font size should correct in search bar

Observed behavior:

font size are setting to 12

Screenshots and GIFs

screenhunter_02 may 19 16 27 screenhunter_01 may 19 16 23

Atom version: 1.17.0 OS and version: Win7

Installed packages:

Atom material UI and syntax theme

silvestreh commented 7 years ago

Good catch, but you won't get the exact same size.

This feature should probably be renamed because it affects the entire UI, not just text. Buttons, for example, aren't being correctly resized for the same reason: they are using fixed UI variables (@component-line-height and @component-padding) instead of being based off of this value.

ryanaltvater commented 7 years ago

@silvestreh I can confirm on Windows that this setting does not do anything. When I disable the theme, my UI font sizes are fine. When it's enabled, all UI fonts are roughly 12px and almost unreadable. I do not have this problem on my MacBook.

Atom version: 1.19.0 Atom Material UI version: 2.0.4 OS version: Windows 10