Closed jneuendorf closed 7 years ago
It appears that this feature is completely broken, having Generate complementary secondary color
enabled causes the secondary colour to reset to #FF0000
upon restarting Atom.
The feature is working as intended. This probably just needs a different label. After enabling the feature you should not get a new color, it only happens after changing the primary color or, given how the atom.config.observe
works, when the theme is reloaded you should also get a new secondary color.
@wyqydsyq I cannot reproduce that. If your primary color is #00FFFF
you'd get #FF0000
. Would you mind filing a new issue with more info?
Please do note that if you pick a color preset and the Generate complementary color
feature is enabled, you'll get a different secondary color once you restart Atom.
Oh I guess that's working as intended then. Perhaps the option should be renamed "Generate contrasting secondary color" because #FF0000
contrasts with #00FFFF
more than compliments it.
They are complementary colors in the RGB color model 😄
I first thought there was a bug concerning the persistency of the secondary color's value. This was due to the fact that toggling
Generate complementary secondary color
did not change the secondary color value on the fly.Reproduction Steps:
atom-material-ui
's settings from Atom -> Settings -> ThemesGenerate complementary secondary color
Generate complementary secondary color
Expected behavior:
When toggling
Generate complementary secondary color
the value of the secondary color should change immediately. Thus the colored square should change its color and the applied editor styles should also change.Observed behavior:
Checking
Generate complementary secondary color
after choosing a secondary color (whileGenerate complementary secondary color
was unchecked) has no effect (only after reloading the window).Atom version: 1.17.0 OS and version: macOS Sierra 10.12.4 (16E195)
Installed packages: