atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
816 stars 203 forks source link

PHP Syntax Highlighting Issues #436

Closed anthony-pinskey closed 6 years ago

anthony-pinskey commented 6 years ago

Hello,

It seems atom-material-ui has suddenly started to fail with the syntax highlighting on PHP files.

Reproduction Steps:

  1. Installed a fresh copy of atom to ensure no other packages were conflicting
  2. With all other packages removed, I installed atom-material-ui

Expected behavior:

Observed behavior:

The syntax color shows orange highlighting on the method brackets instead of the blue on the first method defined within a class. If you remove the first method, it then increments to the next but only does it on the first method.

• Method opening and closing brackets incorrectly colored • Method invoking parenthesis () are incorrectly colored

It also affects the color of the import statements

Atom version: 1.20.0 OS and version: macOS Sierra 10.12.5 Last Known Working Atom Version: 1.19.4

Installed packages:

All other packages removed and uninstalled to ensure no conflicts.

Notes: The syntax highlighting seems to have broken with one of the latest Atom updates. They may have deprecated a certain feature that caused this. This issue does not occur in Atom 1.19.4

anthony-pinskey commented 6 years ago

Closed and moved to the appropriate repository responsible for syntax:

https://github.com/atom-material/atom-material-syntax/issues/80