search

atom-material / atom-material-ui

A dynamic UI theme for Atom that follows Google's Material Design Guidelines
MIT License
817 stars 203 forks source link

Little problem with the tab-bar's background color #468

Closed mmontagnana closed 5 years ago

mmontagnana commented 6 years ago

Hi. I'm using the atom-material-ui theme, together with the three material syntax themes. In the Atom Material theme I tried both a predefined color and a custom color, and I noticed that not all the syntax themes honor the choice I made on the UI theme: the Atom Material Dark Syntax Theme is correct, whereas Atom Material and Atom Material Light Syntax Themes color the tab bar in Teal, no matter what I chose

Reproduction Steps:

  1. In Atom's Settings, choose the Atom Material UI Theme
  2. In the theme's settings, change either a Primary color or a Predefined color
  3. Try different syntax themes, and look at the tab bar

Expected behavior:

The different syntax themes should honor the color I chose in the UI theme's settings

Observed behavior:

Atom Material, Atom Material Light, and Atom Dark core theme always use the Teal color on the tab bar, scroll bars and settings' category; Atom Material Dark and the other core themes correctly use the color I chose in the UI theme's settings

Screenshots and GIFs

image image image

Atom version: 1.25.0 OS and version: Windows 10 Enterprise 1709, Build 16299.309

Installed packages:

I also disabled a few core packages...

mmontagnana commented 6 years ago

I see this problem has already been reported, sorry for the duplicate.

Anyway, I started Atom in Dev mode and I noticed that all the syntax themes worked as expected. I exited the Dev mode and restarted Atom normally, and it still seems that everything's ok. Better saying, it was ok with the two Atom Material syntax themes which gave me problems before, while I saw that the Atom Dark syntax theme was still Teal-based on the tab bar.

I started again Atom in Dev mode, switched to Atom Dark syntax and it was ok; starting back Atom in normal mode retained the cure, so all the syntax themes are perfect now.