search

atom-ocaml / ocaml-merlin

Linting and autocompletion for Ocaml in Atom
MIT License
24 stars 3 forks source link

Changed the text and background colors in the ocaml-merlin-bubble #10

Closed jakub-zwolakowski closed 8 years ago

jakub-zwolakowski commented 8 years ago

Before, what was written in the bubble was not legible, at least in the theme I use, as the text had almost the same color as the background. Now it's much better.

I imagine that in other themes this problem didn't appear, probably text of @base-background-color looked fine on the background of @background-color-info, or otherwise someone would notice the problem before. I hope that text of @text-color-info will look good on the background @background-color-info in any theme. I assume that the "-color-info" suffix in color names means that these two are supposed to be used together.

314eter commented 8 years ago

This is not legible with the one-dark-ui theme. Can you try these colors with your theme?

color: darken(@text-color-info, 40%);
background-color: fade(lighten(@background-color-info, 10%), 90%);

This is very similar to the colors of notifications, so I suppose this should be fine with all themes.

jakub-zwolakowski commented 8 years ago

Ok, perfect! Thanks :)

atom-colors