added favicon to the page

atom-robotics-lab / atom-robotics-lab.github.io

Main Website of ATOM Robotics

https://atom-robotics-lab.github.io/

GNU Affero General Public License v3.0

0 stars 8 forks source link

added favicon to the page #19

Closed Deevyn9 closed 2 years ago

Deevyn9 commented 2 years ago

Signed-off-by: Divine deevynobeten@gmail.com

Kartik9250 commented 2 years ago

Hey @Deevyn9, Thank you for your PR.

We have tested the changes and would like to suggest some further improvements:

remove the .vscode files for your commits and add them to gitignore
use icon that has white background for the favicon

After these changes we can merge your PR.

Deevyn9 commented 2 years ago

Okay, I'll work on them now

jasmeet0915 commented 2 years ago

Hi @Deevyn9, Thank you for such quick response. I have tested the changes and they seem fine!

I see you have added the .vscode to the .gitignore but you haven't removed it from existing commits like @Kartik9250 suggested. I think doing something like:

git rm -r --cached .vscode

should work. Once you do this and push your changes we will be good to go ahead with the merge!

Deevyn9 commented 2 years ago

will do this right away

Deevyn9 commented 2 years ago

done this, looking forward to the merge.

jasmeet0915 commented 2 years ago

Looks fine! I have merged your changes to main. It should reflect on our website if everything goes right. Thank you for your contribution!

Deevyn9 commented 2 years ago

You're welcome!