search

atom-robotics-lab / ros-perception-pipeline

This is a ROS 2 based plug-and-play perception pipeline which can be customised to your need
https://atom-robotics-lab.github.io/
8 stars 9 forks source link

testing and debugging yolov8_plugin #29

Closed sanchayvashist closed 1 year ago

sanchayvashist commented 1 year ago

Tested Yolov8 plugin and made neccesary changes

topguns837 commented 1 year ago

Remove this print statement from here : https://github.com/atom-robotics-lab/ros-perception-pipeline/blob/7d5b73de84c57eab5aaf6b073ee12bb07419ca0d/object_detection/object_detection/ObjectDetection.py#L108

topguns837 commented 1 year ago

Use the create_predictions_list function from the Base class by using

 super().create_predictions_list(class_ids, confidences, boxes)

https://github.com/atom-robotics-lab/ros-perception-pipeline/blob/7d5b73de84c57eab5aaf6b073ee12bb07419ca0d/object_detection/object_detection/Detectors/YOLOv8.py#L56

sanchayvashist commented 1 year ago

Incorporated the changes suggested by @topguns837 ,please review the updates

topguns837 commented 1 year ago

image @sanchayvashist can you take a look into whether these automatically generated logs can be removed ?

sanchayvashist commented 1 year ago

@topguns837 Removed automatically generated logs