atom / apm

Atom Package Manager
https://atom.io/packages
MIT License
1.27k stars 293 forks source link

git packages with access problems can break `apm outdated` and by extension atom's settings view package update #606

Open thedaniel opened 7 years ago

thedaniel commented 7 years ago

My packages stopped being able to update in Atom with the helpful error Fetching outdated packages and themes failed: undefined a while ago and I couldn't figure out what the heck was going on. I ran apm outdated in Terminal, and it asked me for my github.com password (twice)

[untitled folder]> apm outdated
Username for 'https://github.com': Username for 'https://github.com':

I realized I had 2 packages installed from git via apm, and both of them belonged to an org I didn't have access to anymore. After uninstalling those packages, apm outdated worked again.

Desired behavior: git packages that you've lost access to don't make apm outdated hang asking for a password, since atom's settings view depends on that to have output. Probably just ignore them and move on in that case.

thomasjo commented 7 years ago

Probably just ignore them and move on in that case.

Yeah. It would be nice to display a warning or some such though.

prokopsimek commented 7 years ago

+1

fdutheil commented 7 years ago

+1. Moreover, I had to manually use "apm uninstall " to remove a git package, even if it had been previously removed from Atom 1.14.3 GUI (it was still visible by apm and still causing the update issue).

Thank you for reporting this issue, I was able to fix my packages update problem.

a7madgamal commented 7 years ago

this was the hardest and most annoying error I ever had with atom so far. It blocked my updates for about a month :(

Bertg commented 7 years ago

Same thing here. It even seemed to stop the core updates.

We just got "undefined" as the output on console and in the editor. The broken package was "seti-syntax", installed via git.

crucialfelix commented 7 years ago

See also: https://github.com/atom/apm/issues/620

Same type of failure. In my case it was seti-ui which was uninstalled but was still in the packages folder.

mrstux commented 6 years ago

... wrong bug...