atom / apm

Atom Package Manager
https://atom.io/packages
MIT License
1.26k stars 295 forks source link

Support using conventional commits or alternative messages for the Git publish commit #829

Open dmoonfire opened 5 years ago

dmoonfire commented 5 years ago

Prerequisites

Description

In publish.coffee, the message is hard-coded to use Preparing %s release. However, if I'm using conventional commits and commitlint (and associated tooling), the resulting message should be closer to chore(release): preparing v%s release.

Since the publish process is (relatively) atomic, there is no way of interrupting it to have the proper message before it is pushed up and the rest of the logic goes through.

Steps to Reproduce

  1. Use conventional commits.
  2. apm publish minor

Expected behavior:

I expect to have the ability to override or reformat the message.

Actual behavior:

The message is hard-coded.

Reproduces how often: 100%

Versions

Linux, but this is related to how the code works.

Atom    : 1.35.0-beta0
Electron: 2.0.16
Chrome  : 61.0.3163.100
Node    : 8.9.3

apm  2.1.3
npm  6.2.0
node 8.9.3 x64
atom 1.35.0-beta0
python 2.7.15+
git 2.19.1

Additional Information

I like having the ability to track changes, generating change logs, and moving toward the semantic releases. Conventional commits help with that, in my opinion, which is why I've been migrating various libraries over.

ThatXliner commented 3 years ago

I would like that too. Maybe a new command-line option to customize the commit message could be added.