search

atom / apm

Atom Package Manager
https://atom.io/packages
MIT License
1.27k stars 294 forks source link

feat: update the bundled Node version to match Atom-Electron 9 #916

Closed aminya closed 3 years ago

aminya commented 3 years ago

Description of the Change

feat: update the bundled Node version to match Atom-Electron 9

https://www.electronjs.org/blog/electron-9-0

Benefits

Matching the same Node version means more stability across the whole Atom ecosystem.

Verification Process

The tests/CI pass

aminya commented 3 years ago

@sadick254 @darangi This again has caused many issues for us. The Linux users are reporting failures with installing Hydrogen while everything is already provided. Apm detects the ABI version as 72 while Atom uses Electron 9 which is ABI 80! Could you please merge this as soon as possible?

https://github.com/nteract/hydrogen/issues/2091#issuecomment-821977900