Closed as-cii closed 7 years ago
@as-cii The ArchiveEditor
class should define an onDidDestroy
handler for any packages that subscribe to closing pane-items. It's really the only subscription method worth keeping for parity with ordinary TextEditor
instances... a package or theme might subscribe to a pane-item's close event via a tab's .item
property.
Which is how it made its presence known in File-Icons' spec-suite.
LGTM!
Tested the following file formats: .epub .jar .love .nupkg .tar.gz .war .zip .whl .xpi
This pull request is a substantial rewrite of almost the whole package. Every file that was previously using jQuery has now been converted to JavaScript and its dependency on atom-space-pen-views has been removed too. I also believe the logic for jumping between files via the keyboard shortcuts has been greatly simplified as it doesn't rely on the DOM anymore.
Feature-wise nothing should have changed, but this is another step toward removing jQuery from Atom.
/cc: @ungb