Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Description of the Change
This refactors archive-view to be more in line with how similar packages are designed. Notable changes:
Remove ArchiveEditor class and make the entry file an object instead of a class
Move all view instantiation to ArchiveEditorView instead of splitting it between ArchiveEditor and ArchiveEditorView
Move all pane item methods to ArchiveEditorView
Move file event listeners into the ArchiveEditorView constructor and remove the confusingly-named setModel method
Update title and archive view on file rename
Alternate Designs
None.
Benefits
Better separation of concerns between ArchiveEditor (package lifecycle and services) and ArchiveEditorView (the view and pane item).
Possible Drawbacks
Unintentionally-introduced bugs as a result of the file restructuring.
This might also break any saved state that was relying on the ArchiveEditor deserializer name instead of the new ArchiveEditorView. I'll have to look through the commit history and then implement a shim if necessary.
I've added back the old ArchiveEditor deserializer to ensure smooth transitions to the new deserializer. After a few versions have passed it should be safe to remove it.
Requirements
Description of the Change
This refactors archive-view to be more in line with how similar packages are designed. Notable changes:
ArchiveEditorclass and make the entry file an object instead of a classArchiveEditorViewinstead of splitting it betweenArchiveEditorandArchiveEditorViewArchiveEditorViewArchiveEditorViewconstructor and remove the confusingly-namedsetModelmethodAlternate Designs
None.
Benefits
Better separation of concerns between
ArchiveEditor(package lifecycle and services) andArchiveEditorView(the view and pane item).Possible Drawbacks
Unintentionally-introduced bugs as a result of the file restructuring.
This might also break any saved state that was relying on theI've added back the oldArchiveEditordeserializer name instead of the newArchiveEditorView. I'll have to look through the commit history and then implement a shim if necessary.ArchiveEditordeserializer to ensure smooth transitions to the new deserializer. After a few versions have passed it should be safe to remove it.Applicable Issues
None.