search

atom / atom-keymap

Atom's selector-based keymap system
MIT License
105 stars 58 forks source link

Don’t handle keyboard events that are part of IME compositions #180

Closed nathansobo closed 8 years ago

nathansobo commented 8 years ago

We detect IME compositions via a quirk in Chrome’s legacy KeyboardEvent.keyCode property, which is always 229 when a composition is in progress.

Closes #172 Closes #177

@ungb there's really no good way to test this programmatically. We'll need to always be sure to test IME interactions when we upgrade Electron, but it does seem really unlikely that the Chrome team is going to mess with any of these code paths because this keyCode property is deprecated.