search

atom / atom-keymap

Atom's selector-based keymap system
MIT License
105 stars 58 forks source link

Add a "build" method to construct KeyBindings #218

Closed smashwilson closed 7 years ago

smashwilson commented 7 years ago

This would be helpful in fixing atom/settings-view#946, the root cause of which is the use of atom.keymaps as the source of truth for the keybindings provided by a specific package. It'll let me construct and render KeyBindings for a package even while its keybindings are disabled (or the package itself is disabled, for that matter).

smashwilson commented 7 years ago

@as-cii I'd :heart: some feedback on this if you get a moment, especially because it adds a new (extended) method to the public API. If there's another way to do this using the existing API without a bunch of copy and paste that I'm just missing, I'd be happy to avoid doing so.

🙇

smashwilson commented 7 years ago

@as-cii I mean tomorrow when you're not on vacation of course 😆

Sorry, I knew Nathan was off, didn't check the calendar before picking a reviewer :notes: