Support custom dvorak QWERTYCMD layouts

atom / atom-keymap

Atom's selector-based keymap system

MIT License

105 stars 58 forks source link

Support custom dvorak QWERTYCMD layouts #226

Closed Ben3eeE closed 7 years ago

Ben3eeE commented 7 years ago

Restores #90 Fixes https://github.com/atom/atom-keymap/issues/225

When restoring this in https://github.com/atom/atom-keymap/commit/b823c1e5e3a809ab51479d75a7d97dbc1538b3a9 it seems that we did not consider the changes that were added in #90 to enable the workaround for custom DVORAK-QWERTYCMD layouts.

This PR aims to restore this behavior and adds a test so it doesn't regress in the future!

/cc: @ungb @rsese

ungb commented 7 years ago

UPDATE: I was able to test this out. I mistakenly thought this was a apm package. Thanks @Ben3eeE for clarifying it's a npm package.

After testing I saw the following: works

KeyboardLayout:

org.unknown.keylayout.DVORAK-QWERTYCMD

LGTM 🚢

Ben3eeE commented 7 years ago

@ungb Your gif is not running Atom in dev mode which is required for testing this PR. I changed the test to use this layout name and they still pass.

sergiopvilar commented 7 years ago

Thank you so much guys!

Ben3eeE commented 7 years ago

@sergiovilar Sorry for the regression. It seems we overlooked this when rewriting atom-keymap for international keyboard support because there was no test for this. I've restored the behavior and added a regression test.

This fix is currently scheduled to be released in Atom 1.23