:arrow_up: keyboard-layout@2.0.17 (and rename deprecated "prepublish" script to "prepare")

DeeDeeG commented 3 years ago

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

Bump the keyboard-layout package to version 2.0.17.

Alternate Designs

Fix the code warning in the keyboard-layout package, I guess.

Benefits

Includes https://github.com/atom/keyboard-layout/pull/59, which allows the module to compile on Windows 32-bit against Electron 10 and newer, by ignoring a compilation warning that would otherwise be treated as a hard error.

Possible Drawbacks

None, unless that compilation warning was important. :shrug:

Applicable Issues

https://github.com/atom/keyboard-layout/issues/58.
https://github.com/atom/atom/pull/22687 (Helps Atom build with Electron 11 on Windows 32-bit.)

DeeDeeG commented 3 years ago

Unrelated, but I recommend renaming the prepublish script to prepare in package.json, similar to the other packages that was done for recently.

https://github.com/atom/atom-keymap/blob/v8.2.14/package.json#L7

I can add that to this PR if you want, or open another PR. But it's a pretty simple edit.

sadick254 commented 3 years ago

@DeeDeeG you can add it to this PR no problem.

DeeDeeG commented 3 years ago

@sadick254 okay, I pushed the updated package.json script name.

atom / atom-keymap