search

atom / atom-languageclient

Language Server Protocol support for Atom (the basis of Atom-IDE)
https://ide.atom.io/
MIT License
389 stars 78 forks source link

Add support for willSaveWaitUntil request #176

Closed laughedelic closed 6 years ago

laughedelic commented 6 years ago

I see that it's not supported at the moment:

https://github.com/atom/atom-languageclient/blob/e0b9aeb7b8b61538e004c680b16ddc7384c98301/lib/auto-languageclient.js#L115

textDocument/willSaveWaitUntil request is useful for example to run formatting before the document is saved.

laughedelic commented 6 years ago

Sorry, I see that it has been mentioned in #138. Feel free to close it. By the way, does it make sense to contribute anything at the moment or it's better to wait until #175 gets merged?

damieng commented 6 years ago

It shouldn't matter either way. The TypeScript conversion will be wrapped up this week but we can retroactively convert any new work on top of it.