atom / atom-languageclient

Language Server Protocol support for Atom (the basis of Atom-IDE)
https://ide.atom.io/
MIT License
389 stars 78 forks source link

Do not use autocomplete cache unless explicit trigger character is set #209

Closed hansec closed 6 years ago

hansec commented 6 years ago

During an autocomplete request if no explicit trigger character is set the cache should not be reused as we cannot tell from the trigger character alone (always "") if the prefix is the same. This manifests as a bug when a user changes the prefix after an autocomplete request has been serviced and the autocomplete results are not updated.

damieng commented 6 years ago

Thanks!