Clean up atom typings - Githubissues

atom / atom-languageclient

Language Server Protocol support for Atom (the basis of Atom-IDE)

https://ide.atom.io/

MIT License

389 stars 78 forks source link

Clean up atom typings #214

Closed lierdakil closed 6 years ago

lierdakil commented 6 years ago

This PR is concerned with preferring Atom definitions from DefinitelyTyped, instead of the home-grown variety -- mostly related to autocomplete-plus types.

One thing of note, it replaces TextEditor.getURI() with TextEditor.getPath(). Several reasons for that:

getURI has been semi-deprecated since v0.200 or something like that
it's not documented on atom.io
it does exactly the same as getPath

Not entirely sure how it got there in the first place.

lierdakil commented 6 years ago

This is ready to be reviewed/merged.

damieng commented 6 years ago

Thanks!