atom / atom-languageclient

Language Server Protocol support for Atom (the basis of Atom-IDE)
https://ide.atom.io/
MIT License
389 stars 78 forks source link

Autocomplete handling does not meet spec #255

Closed Aerijo closed 5 years ago

Aerijo commented 5 years ago

The spec says that filterText can be provided to be used as the sort and filter keys, and that label is used if it is falsey.

It currently filters on the text key of the converted completion. This value was set to the value of insertText, which can be a full on snippet and so is not a good candidate for filtering, nor following the spec at all.

Aerijo commented 5 years ago

Closed by #262