Closed Gert-dev closed 3 years ago
@Gert-dev This may be fixed on master, could you confirm?
@Aerijo I can and it seems to be fixed on latest master, presumably by 3f44ceb9b8b8174fa115e5e32c14e773471d5c34.
Thanks! Feel free to close this ticket. I'll keep a lookout for a new stable release to target that contains it.
Development of atom-languageclient has officially moved to https://github.com/atom-ide-community/atom-languageclient 🎉
If this is still an issue please consider opening an issue on that repo.
The Serenata server generates autocompletion suggestions that carry a
textEdit
property that can replace characters, for example:In this docblock, with the cursor after the
@inh
text, a suggestion with text@inheritDoc
is generated, which includes atextEdit
that includes the range of the existing@inh
text to ensure it is replaced in its entirety, along with the@
sign.Currently, this
@
sign is not replaced and the result of selecting the completion is:I did some digging and it turns out that the
AutocompleteAdapter
first properly resolves thetextEdit
to thereplacementPrefix
of value@
. However, afterwards, that (correct)replacementPrefix
is then trampled and overwritten by this code inAutocompleteAdapter::getSuggestions
:This resets the
replacementPrefix
of@
to an empty value and seems to be the cause of the double@
symbol being inserted.