search

atom / atom-languageclient

Language Server Protocol support for Atom (the basis of Atom-IDE)
https://ide.atom.io/
MIT License
388 stars 78 forks source link

use rimraf #276

Closed UziTech closed 4 years ago

UziTech commented 5 years ago

Identify the Bug

Doesn't install on window

fixes #275

Description of the Change

use rimraf instead of rm -rf

Possible Drawbacks

none

Verification Process

installed on windows

Release Notes

Fix windows install

Gert-dev commented 5 years ago

This makes me curious, do other language clients work on Windows at all? It seems highly unlikely that we're the first to encounter this error as there have been many language clients for much longer.

php-ide-serenata has only just switched and Windows users now immediately encounter this error.

UziTech commented 5 years ago

It also seems fairly strange that tests pass on appveyor

Gert-dev commented 5 years ago

Hmm, I think I see what the problem is (#166), it is because Serenata is using an unstable version of the atom-languageclient - intentionally, I might add, since I need the targeted commit to fix an issue with autocompletion.

It is likely it'll be solved by targeting a stable release, but autocompletion will be bugged for users. If a new stable release is performed here, that would likely also fix the problem (but this fix might as well).

UziTech commented 5 years ago

@Aerijo @50Wliu @damieng @atom Any feedback?

damieng commented 5 years ago

I left GitHub in the first quarter of 2018 and haven't touched anything Atom related since the end of 2018 when they officially killed Atom IDE off, sorry.

UziTech commented 4 years ago

@atom Could we get this merged so it works on windows and a new release?