atom / atom.io

🌐 A place for feedback on the atom.io website and package API
160 stars 99 forks source link

Improve GitHub microsite accessibility #119

Closed BinaryMuse closed 7 years ago

BinaryMuse commented 7 years ago

From https://github.com/atom/github/issues/832:

I notice the githb-atom website is not accessible for all users.

the navbar inside the main.features have a list of spans that's is when you click on the video above change but as you know the span element is not focusable so you should use <button> instead of <span> to make it accessible for keyboard users.

also, the website a11y need to more work I notice also the icons do not have aria-hidden=true or aria-label whatever you want to the screen reader user read.

/cc @Muhnad who opened the original issue /cc @jasonrudolph @simurai

jasonrudolph commented 7 years ago

@Muhnad: Thank you for bringing this to our attention. We've updated https://github.atom.io to address these issues. If you continue to notice any accessibility issues on https://github.atom.io, please let us know.