atom / atom.io

🌐 A place for feedback on the atom.io website and package API
160 stars 99 forks source link

Markdown lists render incorrectly following a hard line-break #130

Open Alhadis opened 7 years ago

Alhadis commented 7 years ago

I noticed a segment of the file-icons package's readme isn't displaying correctly on atom.io:

Figure 1

On GitHub, however, the list is rendered fine:

Figure 2

Here's the source:


<a name="the-tree-view-keeps-opening-by-itself"></a>
**The tree-view keeps opening by itself when opening a project window:**  
1. Open the dev-tools: **View** β†’ **Developer** β†’ **Toggle Developer Tools**
2. Click the **Console** tab
3. Run the following line, then restart Atom:

~~~js
atom.config.set("file-icons.revealTreeView", false);
~~~

I suspect this may be the fault of different Markdown implementations; which one is Atom.io using? I understand GitHub has switched to CommonMark (or a modestly-tweaked variant of it), so I'm inclined to see this rendering as the "correct" rendering. If Atom.io is using some other implementation, it might be a good idea to switch over sooner or later... =)

Also, would it be possible to add basic diff highlighting to code-blocks tagged as diff? (Or patch?) If you check the file-icons docs, you'll notice the code-chunks aren't as informative as they are on GitHub. For example:

 &[data-name=".git"]:before {
-   .git-icon;
+   font-family: Devicons;
+   content: "\E602";
 }