Busted icons on atom.io website

atom / atom.io

🌐 A place for feedback on the atom.io website and package API

158 stars 98 forks source link

Closed jaredhirsch closed 5 years ago

jaredhirsch commented 5 years ago

Howdy! Noticed some funky-looking icons on the token download page, and it turns out they are visible on the homepage, too.

On https://atom.io, I see this on the far right side of the header:

Firefox: screen shot 2018-09-10 at 11 59 36 am

Chrome: screen shot 2018-09-10 at 12 00 22 pm

And I see this in the footer:

Firefox: screen shot 2018-09-10 at 12 01 14 pm

Chrome: screen shot 2018-09-10 at 12 00 50 pm

50Wliu commented 5 years ago

Confirmed. @queerviolet this is caused by #164.

tambry commented 5 years ago

My guess is this was because the CDN URLs were updated only in the HTML and not also in the CSS, and worked initially, because the CSP didn't apply.

queerviolet commented 5 years ago

Investigated this a bit yesterday and couldn't find where the old CDN url was lurking. Rolled back, will investigate more today.

lee-dohm commented 5 years ago

Since this is fixed and there is another issue tracking the work, I'm going to close this. Thanks for reporting the problem! :bow: