search

atom / atom

:atom: The hackable text editor
https://atom.io
MIT License
60.18k stars 17.39k forks source link

Color issue in 1.4.0 #10414

Closed NimbusFox closed 8 years ago

NimbusFox commented 8 years ago

After updating my atom editor all the colors in all my themes start looking very weird.

Before 1.4.0 image

After 1.4.0 image

The theme in the images above is Seti both ui and syntax

Is this intended in the update or is there a bug?

50Wliu commented 8 years ago

Hi @RoleplayDotNetwork, the Javascript language changed a lot between 1.3.0 -> 1.4.0, which added support for chained methods and properties.

Do you have any suggestions as to what the syntax highlighting should be like?

NimbusFox commented 8 years ago

Ah that would explain it. Thanks @50Wliu Guess it's just something to get use to. Though there was an issue on another project where the bracket color matching was quite off. image The picture above is an argument for a function. The code is one of my work's project so being careful what I share

mnquintana commented 8 years ago

@RoleplayDotNetwork Thanks for the update! In that case, would you mind opening another issue for that bracket syntax highlighting issue on https://github.com/atom/language-javascript? (Also take a look at the open issues in that repo – it might exist already.)

arodic commented 8 years ago

The highlighting changed for me so much that it is close to unusable. Is there any way to revert to 1.3 highlighting scheme?

50Wliu commented 8 years ago

@arodic if you're using one-dark-syntax this comment should help you. Otherwise, a more general solution is available at https://github.com/atom/language-javascript/issues/308#issuecomment-173328656.

In addition, I would greatly appreciate it if you could give some suggestions as to what the highlighting should be like.

arodic commented 8 years ago

@50Wliu thanks I'll look that up. Personally, I prefer the way it was before. For example, in the before/after screenshots below you can see that both this and properties of this are the same color. That makes is harder to visually discern very important this keyword. However, properties are sometimes orange for reason I cannot understand.

before after

50Wliu commented 8 years ago

Ok, when this becomes orange, that's definitely a bug :P. I think we've fixed that but I'll double-check later today just to be sure.

Also, you're in luck - this (and super) can be styled separately using .variable.language.js so that you can give it a unique color.

lock[bot] commented 6 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!