atom / atom

:atom: The hackable text editor
https://atom.io
MIT License
60.22k stars 17.39k forks source link

Uncaught TypeError: Cannot read property 'serialize' of undefined when closing last pane #11002

Closed izuzak closed 8 years ago

izuzak commented 8 years ago

As far as I can tell, this started happening recently, after #10737 was merged. /cc @benogle @natalieogle

Steps to reproduce:

  1. Open a bunch of files
  2. Start closing them one-by-one
  3. Exception is thrown after last one is closed

Here's a GIF (notice how the exception doesn't happen when closing or opening files until the last one is closed):

w

Atom Version: 1.7.0-dev-b589e28 System: Mac OS X 10.11.3 Thrown From: Atom Core

Stack Trace

Uncaught TypeError: Cannot read property 'serialize' of undefined

At /Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:88

TypeError: Cannot read property 'serialize' of undefined
    at Pane.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:88:26)
    at Pane.module.exports.Pane.serialize (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:93:10)
    at PaneContainer.module.exports.PaneContainer.serialize (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:54:51)
    at Workspace.module.exports.Workspace.serialize (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:149:43)
    at AtomEnvironment.module.exports.AtomEnvironment.serialize (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:739:35)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:946:27

Commands

Config

{
  "core": {
    "destroyEmptyPanes": false
  },
  "editor": {
    "fontFamily": "Hasklig",
    "fontSize": 17,
    "invisibles": {},
    "showInvisibles": true
  }
}

Installed Packages

# User
No installed packages

# Dev
No dev packages
natalieogle commented 8 years ago

I'll look into this tomorrow!

benogle commented 8 years ago

Thanks @izuzak for the report

nfantone commented 8 years ago

:+1: Came here for this. Nice to find out it's fixed.

lock[bot] commented 6 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!