atom / atom

:atom: The hackable text editor
https://atom.io
MIT License
60.19k stars 17.39k forks source link

Support MacBook Touch Bar #13224

Closed alexkaessner closed 7 years ago

alexkaessner commented 7 years ago

Would be really nice to have the ability to create Packages for Touch Bar actions. I think it would be nice to maybe have a basic package from Atom. If you want to go specialised you can write your own and add or replace the standard actions. For example, I would love to see Indent and Outdent buttons. The ⌘+] shortcut is on my german keyboard pretty hard to remember as I have to press ⌘+alt+6.

What do you guys think? What would you like to see on a Atom Touch Bar?

PS: I know this has been tracked as Issue for Electron (electron/electron#7781), but let's discuss here what you think about the integration in Atom.

ccdwyer commented 7 years ago

I would love this kind of integration.

NuckChorris commented 7 years ago

I'd love to see the tabs on the touch bar, my vim binding mode, and the git status

dijs commented 7 years ago

👍

TechRemarker commented 7 years ago

Absolutely. What's great about Atom compared to other editors is everything down the the last dot is customizable. So extensive customization of toucher when using Atom would certainly be inline with Atom's approach.

MiracleBlue commented 7 years ago

Would absolutely love to be able to customise the actions for atom on the touch bar. I reckon it should allow the user to add any registered command to the touch bar, for me that would be the most useful, even though having little info tidbits like git status etc would be very nice, I'd be worried about using up the space with things that arent interactive. But that's just me. As long as I can customise the hell out of it, I will be very very happy :)

alexkaessner commented 7 years ago

Just for reference, Coda is using these Touch Bar actions:

Coda screenshot

HaNdTriX commented 7 years ago

https://github.com/electron/electron/pull/8095

shreyasminocha commented 7 years ago

I think I'd like to see minimap integration.

tomdye commented 7 years ago

Git / linting / build status

MoOx commented 7 years ago

At least emojis, I use them a lot in my comments 😂

Niels-NTG commented 7 years ago

I don't think it could be much use for me if it where just buttons. I already have some very ergonomic keybindings for those. Rather I would like to use the touchbar as a replacement for the statusbar.

alexkaessner commented 7 years ago

Yeah…after a few weeks working with my new MacBook I would also say that only buttons is maybe a little to less. At least for the advanced developers out there.

For this reason Atom should allow extensions to change the Touch Bar in any way. So everyone is able create and customize the Touch Bar with anything what suits best for themselves. 👌

Though a standard button action set would be a nice start…

tmcarr commented 7 years ago

@alexkaessner I would argue instead that Atom expose an API so that extension developers can register buttons for the user to add, then the user can add them through the View -> Edit Touch Bar Buttons feature.

I dont want an extension changing a touchbar that I have extensively configured.

alexkaessner commented 7 years ago

@tmcarr You're totally right! Thats the better way to handle this.

evanmhm commented 7 years ago

I would love to be able to switch tabs like on Safari, even without the little previews it would be so useful.

adamscybot commented 7 years ago

There are some nice use cases.

The coolest stuff is contextual. Taking the example with the css colours, the colour picker would appear automatically when you begin to type color:. When you type a function declaration, a button could appear to add the JSDoc. Autosuggest for variable names when you type let or var. List goes on.

Stuff like this could actually be useful rather than duplicating whats on screen.

PeterTeng commented 7 years ago

I think simply showing current branch information if very helpful. Such as branch name commits count behind or ahead.

evanmhm commented 7 years ago

Touchbar support will be included in the next Electron beta release, 1.6.3! More details on the new docs page.

Weuxel commented 7 years ago

When will that be included in Atom?

50Wliu commented 7 years ago

No ETA.

evanmhm commented 7 years ago

Who here knows how to start development on something like this? I am very interested in helping but I have little experience with atom specifically. I've also done some experiments with the Touch Bar support in electron and it's looking pretty good right now.

50Wliu commented 7 years ago

Specifically, we'd need to wait for a stable release of Electron that contains the touchbar support so that we can integrate it into Atom. Updating Atom's Electron version is very high-risk though, so generally that take some time.

IchordeDionysos commented 7 years ago

For the meantime you could use the BetterTouchTool to customize your Touchbar inside Atom the way you want it to and maybe add some useful buttons to it.

Phooto commented 7 years ago

I've tried BetterTouchTool with Mplab, and it really doesn't seem to work. Seems clumsy, at best. Don't waste your money!

davecarlson commented 7 years ago

Electron 1.6.5 is stable now (touchbar was in 1.6.4 beta :) )

LGTFM!! +1

audvin commented 7 years ago

This is awesome news, when is the next planned release of Atom with Touch Bar support?

50Wliu commented 7 years ago

No ETA. We're hard at work updating Atom to use Electron 1.6.5 though. #12696

massontom commented 7 years ago

yeah would be cool to have that ;)

Multiply commented 7 years ago

Now that #12696 is merged, can we assume this arrive in 1.19.x?

50Wliu commented 7 years ago

The functionality to add touch bar actions should be included in Atom 1.19.0, though I doubt that Atom will have some implemented. Does however mean that package authors can start making their own :).

50Wliu commented 7 years ago

Therefore I think this issue can now be closed.

alexkaessner commented 7 years ago

Is there already any (API) reference on how to create these actions with a package?

50Wliu commented 7 years ago

Here's the Electron docs: https://electron.atom.io/docs/api/touch-bar/.

sadovnychyi commented 7 years ago

Sorry for noise, but could be interesting to somebody: API in action: https://github.com/autocomplete-python/autocomplete-python/releases/tag/v1.9.0

lock[bot] commented 6 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!