Closed bnvk closed 8 years ago
@bnvk Can you try updating to the latest version of Atom which is 1.0.11? You're still on 1.0.0.
Let us know if that doesn't help
@izuzak yep, that was it, thanks so much! Strange I wasn't prompted to autoupdate!
[Enter steps to reproduce below:]
Atom Version: 1.0.15 System: Mac OS X 10.10.5 Thrown From: Atom Core
Uncaught Error: Pane has been destroyed
At /Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:631
Error: Pane has been destroyed
at Pane.module.exports.Pane.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:631:15)
at Pane.module.exports.Pane.focus (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:209:21)
at atom-pane.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-element.js:59:23)
-2:29.9.0 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
-2:29.9.0 snippets:expand (atom-text-editor.editor.is-focused)
-2:29.9.0 editor:indent (atom-text-editor.editor.is-focused)
2x -2:29.2.0 atomic-emacs:previous-line (atom-text-editor.editor.is-focused)
-2:20.4.0 core:save (atom-text-editor.editor.is-focused)
-2:18.1.0 command-palette:toggle (atom-text-editor.editor.is-focused)
-2:16.3.0 core:confirm (atom-text-editor.editor.mini.is-focused)
-2:16.3.0 window:save-all (atom-text-editor.editor)
-0:46 pane:show-next-item (atom-text-editor.editor.is-focused)
-0:31.5.0 pane:show-previous-item (atom-text-editor.editor.is-focused)
-0:30.9.0 pane:show-next-item (atom-text-editor.editor.is-focused)
-0:28.7.0 pane:split-down (atom-text-editor.editor.is-focused)
-0:27.1.0 pane:show-previous-item (atom-text-editor.editor.is-focused)
-0:25.2.0 window:focus-next-pane (atom-text-editor.editor.is-focused)
-0:24.7.0 pane:show-previous-item (atom-text-editor.editor.is-focused)
-0:19.4.0 pane:split-right (atom-text-editor.editor.is-focused)
{
"core": {
"openEmptyEditorOnStart": false,
"projectHome": "/projects",
"themes": [
"base-16-ocean-dark-ui-theme",
"base16-ocean-dark-spacegray"
],
"autoHideMenuBar": true
},
"editor": {
"invisibles": {},
"preferredLineLength": 100,
"showIndentGuide": true,
"lineHeight": 1.25,
"scrollPastEnd": true,
"fontFamily": "Source Code Pro"
}
}
# User
atom-yeoman, v0.3.13
atomic-emacs, v0.7.3
autocomplete-glsl, v0.2.3
autocomplete-python, v0.5.3
base-16-ocean-dark-ui-theme, v1.5.1
base16-ocean-dark-spacegray, v0.12.0
ionide-fake, v1.0.3
ionide-fsharp, v1.1.1
ionide-fsi, v1.0.4
ionide-installer, v1.2.1
ionide-paket, v2.0.8
ionide-yeoman, v1.0.1
language-cmake, v0.1.4
language-rust, v0.4.5
linter, v1.6.0
racer, v0.17.2
# Dev
No dev packages
@photex I'm not able to reproduce that problem using the steps you provided. I noticed that you have a few packages installed. Can you reliably reproduce the problem when those packages are enabled, and can you still reproduce the problem in safe mode (i.e. all packages disabled)? Thanks for adding a comment!
@izuzak looks like an issue with ionide. Was raising and exception during startup in fact about not finding mono. Somehow that seems to place it into a bad state? Thanks for the suggestion.
Getting this issue now and figured I'd leave a comment
Steps to reproduce:
All packages are up to date. Could this be a problem with atom/markdown-preview?
Atom Version: 1.0.19 System: Mac OS X 10.10.5 Thrown From: Atom Core
Uncaught Error: Pane has been destroyed
At /Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:631
Error: Pane has been destroyed
at Pane.module.exports.Pane.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:631:15)
at Pane.module.exports.Pane.split (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:722:15)
at Pane.module.exports.Pane.splitRight (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:686:19)
at atom-pane.atom.commands.add.pane:split-right (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-element.js:273:30)
at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:245:29)
at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:184:20)
2x -0:34.7.0 core:close (atom-text-editor.editor.is-focused)
-0:32.2.0 fuzzy-finder:toggle-file-finder (atom-workspace.workspace.scrollbars-visible-always.theme-atom-material-syntax.theme-nucleus-dark-ui)
-0:31.2.0 core:backspace (atom-text-editor.editor.mini.is-focused)
-0:30.3.0 core:confirm (atom-text-editor.editor.mini.is-focused)
-0:28.7.0 command-palette:toggle (atom-text-editor.editor.is-focused)
6x -0:25.6.0 core:backspace (atom-text-editor.editor.mini.is-focused)
-0:24.5.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
-0:24.5.0 core:cancel (atom-text-editor.editor.mini.is-focused)
-0:24.1.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.is-focused)
-0:21.3.0 core:confirm (atom-text-editor.editor.mini.is-focused)
-0:15 pane:show-previous-item (atom-text-editor.editor.is-focused)
-0:14.4.0 command-palette:toggle (atom-text-editor.editor.is-focused)
-0:13 core:confirm (atom-text-editor.editor.mini.is-focused)
-0:13 markdown-preview:toggle (atom-text-editor.editor)
-0:09.9.0 core:move-down (atom-text-editor.editor.is-focused)
-0:01.1.0 pane:split-right (div.markdown-preview.native-key-bindings)
{
"core": {
"disabledPackages": [
"close-tags",
"autoclose-html",
"atom-pair",
"linter-rubocop",
"linter",
"vim-mode"
],
"themes": [
"nucleus-dark-ui",
"atom-material-syntax"
]
},
"editor": {
"invisibles": {},
"showIndentGuide": true
}
}
# User
atom-beautify, v0.28.14
atom-material-syntax, v0.2.4
color-picker, v2.0.13
editor-stats, v0.17.0
minimap, v4.13.4
minimap-find-and-replace, v4.3.0
minimap-git-diff, v4.1.8
nucleus-dark-ui, v0.5.14
toggle-packages, v1.0.1
# Dev
toggle-packages, v1.0.1
Thanks, @AEgan -- I'm seeing that as well, so I'm reopening this.
Even if this is a problem in markdown preview, Atom should be smarter about blaming that package in the exception, instead of Atom core. But I think it
/cc @nathansobo for more :thought_balloon:
Seeing a lot of these exceptions in bugsnag, so I'm going to put this on my list of issues to investigate more deeply this week.
The Markdown Preview error is due to the original tab that contained the markdown being closed. When attempting to split the Preview, markdown-preview tries to look for the original tab, and when it can't find it, immediately deletes the pane. However we're still trying to add the preview over in pane.coffee
to the (now) deleted pane, which leads to this error. The other pane-related issues may be better suited over at #10903.
[Enter steps to reproduce below:]
Atom Version: 1.5.4 System: Microsoft Windows 7 Professional Thrown From: Atom Core
Uncaught Error: Pane has been destroyed
At C:\Users\kcrow\AppData\Local\atom\app-1.5.4\resources\app.asar\src\pane.js:631
Error: Pane has been destroyed
at Pane.module.exports.Pane.activate (C:\Users\kcrow\AppData\Local\atom\app-1.5.4\resources\app.asar\src\pane.js:631:15)
at Pane.module.exports.Pane.focus (C:\Users\kcrow\AppData\Local\atom\app-1.5.4\resources\app.asar\src\pane.js:207:21)
at atom-pane.<anonymous> (C:\Users\kcrow\AppData\Local\atom\app-1.5.4\resources\app.asar\src\pane-element.js:50:23)
-4:51.4.0 editor:newline (atom-text-editor.editor.autocomplete-active.is-focused)
-4:51 core:paste (atom-text-editor.editor.autocomplete-active.is-focused)
-4:50.6.0 editor:newline (atom-text-editor.editor.autocomplete-active.is-focused)
-4:50.2.0 core:paste (atom-text-editor.editor.autocomplete-active.is-focused)
-4:49.9.0 editor:newline (atom-text-editor.editor.autocomplete-active.is-focused)
-4:49.5.0 core:paste (atom-text-editor.editor.autocomplete-active.is-focused)
-3:15.8.0 core:backspace (atom-text-editor.editor.autocomplete-active.is-focused)
-2:36.1.0 editor:newline (atom-text-editor.editor.is-focused)
-2:35.7.0 core:paste (atom-text-editor.editor.is-focused)
-2:23.3.0 core:backspace (atom-text-editor.editor.is-focused.autocomplete-active)
-2:20.1.0 core:save (atom-text-editor.editor.is-focused)
-1:58 tabs:split-right (li.tab.sortable.active.right-clicked)
3x -1:27.5.0 browser-plus:open (atom-text-editor.editor.is-focused)
-0:47.1.0 settings-view:uninstall-packages (atom-text-editor.editor.is-focused)
2x -0:25.1.0 pane:close (ul.list-inline.tab-bar.inset-panel)
-0:11.9.0 application:new-file (ul.list-inline.tab-bar.inset-panel)
{
"core": {
"disabledPackages": [
"wrap-guide"
]
},
"editor": {
"invisibles": {},
"preferredLineLength": 100,
"softWrap": true,
"softwrap": true
}
}
# User
angularjs, v0.3.4
atom-live-server, v1.2.5
autoclose-html, v0.23.0
browser-plus, v0.0.54
open-in-browser, v0.4.6
# Dev
No dev packages
For what it's worth, you may be able to work around this issue by splitting left instead of right. Worked for me in one instance, anyhow.
I see release after release of atom not fixing this... it's so annoying to reload the window every time this happens, how come it's not a priority?
@invernizzie I was under the impression it's a bug in a package. Can you post a full stack trace next time it happens?
👋 @nathansobo
same steps as before:
I did some more testing, and figure it's worth noting that I cannot reproduce this with the editor core setting "Remove Empty Panes" disabled. My guess would be that splitting a pane with that setting enabled might attempt to generate the preview from the markdown file, which had just been closed, where the disabled option will result in an empty pane and no error. I've never looked at the code for markdown preview, so that's just my guess ¯_(ツ)_/¯.
Hope that helps, and thanks for taking a look!
Atom Version: 1.11.0-beta5 Electron Version: 0.37.8 System: Mac OS X 10.10.5 Thrown From: Atom Core
Uncaught Error: Pane has been destroyed
At /Users/distiller/atom/out/app/src/pane.coffee:832
Error: Pane has been destroyed
at Pane.module.exports.Pane.activate (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/pane.js:832:15)
at Pane.module.exports.Pane.split (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/pane.js:928:15)
at Pane.module.exports.Pane.splitRight (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/pane.js:884:19)
at atom-pane.commandRegistry.add.pane:split-right-and-copy-active-item (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/register-default-commands.js:253:32)
at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/command-registry.js:3:61
at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:580:16)
at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:388:22)
at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/window-event-handler.js:114:36)
at HTMLDocument.<anonymous> (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61)
-0:28.7.0 blur (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
-0:27.5.0 core:close (atom-workspace.workspace.scrollbars-visible-always.seti-ui-no-icons.theme-base16-syntax.theme-nucleus-dark-ui)
3x -0:27.4.0 blur (div.markdown-preview.native-key-bindings)
-0:25.5.0 pane:split-right-and-copy-active-item (div.markdown-preview.native-key-bindings)
2x -0:25.5.0 blur (div.markdown-preview.native-key-bindings)
-0:23.7.0 fuzzy-finder:toggle-file-finder (atom-pane.pane.active)
-0:23.7.0 blur (atom-pane.pane.active)
-0:23.1.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
-0:23.1.0 core:cancel (atom-text-editor.editor.mini.is-focused)
-0:23.1.0 blur (atom-text-editor.editor.mini.is-focused)
-0:18.9.0 settings-view:open (atom-pane.pane.active)
15x -0:18.8.0 blur (atom-pane.pane.active)
-0:02.1.0 core:close (div.panels-item)
4x -0:02.1.0 blur (div.panels-item)
-0:00.3.0 pane:split-right-and-copy-active-item (div.markdown-preview.native-key-bindings)
2x -0:00.3.0 blur (div.markdown-preview.native-key-bindings)
Yes, this is a known bug in markdown-preview. I have a PR that fixes it at https://github.com/atom/markdown-preview/pull/375.
Cool, this seems to have slipped through the cracks. Feel free to merge that PR @50Wliu. If you need any additional support ping me in channel.
I just went ahead and merged and published the fix. Thanks @50Wliu!
@nathansobo thanks for your comment. I don't use markdown-preview and am getting this error anyway. Must be another package with a similar bug. I'll try to reproduce later and report back.
@invernizzie I believe this error without markdown preview is currently being tracked in https://github.com/atom/atom/issues/12498 which reproduces with the settings view. Are you reproducing with the settings view or do you have separate steps? Seems some are reproducing without the settings-view but we don't have any steps for that.
This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!
[Enter steps to reproduce below:]
Atom Version: 1.0.0 System: "Fedora release Thrown From: Atom Core
Stack Trace
Uncaught Error: Pane has been destroyed
Commands
Config
Installed Packages