search

atom / autocomplete-emojis

autocomplete+ emoji autocompletion
https://atom.io/packages/autocomplete-emojis
MIT License
74 stars 20 forks source link

Image Links broken in README #17

Closed robbawebba closed 7 years ago

robbawebba commented 7 years ago

Just letting you know that the image links used in the README appear to be broken. The same problem occurs in the browser and in the settings page for this Atom package.

Browser (IE Edge):

no-images-web

Atom:

no-images-atom
rsese commented 7 years ago

Thanks for the report @robbawebba, opening a quick PR now :v:

eqot commented 7 years ago

Hi @robbawebba,

Thank you very much for pointing it out. Those images are located in DropBox but recently invisible due to DropBox's change.

I have copied all images from DropBox to this repository and update all URLs.

robbawebba commented 7 years ago

Sweet, thanks @eqot! Also, just a heads up, @rsese's PR #18 is still open and made the same changes as you so that may cause a merge conflict.

rsese commented 7 years ago

Oh great, thanks @eqot :bow:! Also thanks for moving the images URLs off of DropBox.

I can just close my PR since you fixed the images and we can open a new one for any other small updates we wanted to make (e.g. the capitalization, @ben3eee's suggestion about just talking about the Settings in text rather than an image, etc.).